Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Python 2 and dependency on future #606

Closed
frenzymadness opened this issue Aug 29, 2023 · 2 comments · Fixed by #626
Closed

Python 2 and dependency on future #606

frenzymadness opened this issue Aug 29, 2023 · 2 comments · Fixed by #626

Comments

@frenzymadness
Copy link

Hi. I see future in the list of dependencies and I've found only this one usage of it:

if sys.version < "3":
from future.standard_library import install_aliases
install_aliases()

Do you still need to support Python 2? I'm asking because future is broken with the latest Python 3.12 and will be even more with 3.13 so it might be a good idea to get rid of it.

@musicinmybrain
Copy link
Contributor

This appears to be fixed in unreleased commit 55e3373, which conditionalizes the dependency on the Python interpreter version and replaces most uses of future with six. When I run tox -e py313 on current master, 9a90bd6, I get only one test failure in test_wrapped_name_and_docs (which is due to the new behavior of stripping indentation from docstrings).

@musicinmybrain
Copy link
Contributor

test_wrapped_name_and_docs

#619

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants
@frenzymadness @musicinmybrain and others