-
Notifications
You must be signed in to change notification settings - Fork 917
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: migrate to hatch + use hatchling for the build backend, drop Python 2 support #626
Conversation
See #618 where this will be rebased to
I'm hitting the same error as the other PR, which suggests that the problem is with either Hatch or PyPy-3.10-Windows – changing the build backend did not work. Either way, I'm sure these changes are beneficial. I guess it should be safe to drop this platform and test just PyPy-3.10-Ubuntu and PyPy-3.10-macOS. @fjosw, what do you think? |
Similar error: actions/runner-images#5009 – I bumped |
Looking at the logs, the installation time for all platforms on PyPy is unusually high. It shouldn't take thirteen minutes just to install a pure Python project at all. |
Hey @agriyakhetarpal, I would be fine with not running PyPy tests on windows, or even dropping all PyPy tests if they cause so many troubles, whatever you prefer. |
Sure, I dropped it for just Windows for now, since it's tested elsewhere and PyPy 3.9 is passing for Windows. I have a branch locally for switching to |
Lots of potential improvements and maintenance to do, I'm excited 😄 |
Just realised I pushed the previous commit to |
I don't have access to change branch protection rules in the settings. @j-towns, could you please help us out with this? Also, since not many PRs are active, we could additionally look at renaming |
Yep, since they're not urgent I'll look at those things in around 10 days when I'm back from holiday. |
Sure, thanks! Enjoy your holiday! |
@fjosw, please let me know if this is good to go for you – I'm awaiting your review :) I think it is, at least from my end. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @agriyakhetarpal, sorry for the delay, your changes look good to me! I guess "numpy<2" is only temporary to let the tests pass?
Thanks for the review, and no worries about the delay! Yes, the upper pin is just temporary – just updated your branch in the other PR where the pin doesn't exist 😄 |
Description
autograd
has been migrated to usehatchling.build
instead ofsetuptools.build_meta
as the build backend. Some missing metadata entries have been added inpyproject.toml
.six
andfuture
libraries has been removed, since all of the code is compatible with Python 3.py3
for the Python tag instead ofpy2-py3
.What issue does this PR close/address?
Closes #606
Closes #513, since we won't need
setuptools
-specific files anymore.Caveats (i.e., tasks for future PRs)
hatch-vcs
plugin to derive the version from Git; andtox
through the addition of a[tool.hatch.run]
table inpyproject.toml
.Additional notes
The
conda.yaml
file doesn't look like it's going to work anyway; I'll modify this in another PR and switch to anenvironment.yaml
file if needed, or we can drop it sometime soon: all of our dependencies both for regular usage and development work are available via PyPI.