Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixing knowledge_graph keyword bug #141

Merged
merged 1 commit into from
Oct 26, 2024

Conversation

Yazington
Copy link
Contributor

@Yazington Yazington commented Oct 26, 2024

@Dormiveglia-elf
Copy link
Contributor

Please refer to PR #123
I think that you didn't modify anything bro.

@LarFii
Copy link
Collaborator

LarFii commented Oct 26, 2024

The typos have been fixed in the latest code. : )

@LarFii LarFii closed this Oct 26, 2024
@tackhwa
Copy link
Contributor

tackhwa commented Oct 26, 2024

@LarFii i think there is still few typo knwoledge_graph_inst in operate.py, can you please fix it?, in _merge_edges_then_upsert and few other methods also

@LarFii
Copy link
Collaborator

LarFii commented Oct 26, 2024

You're right; that was an oversight on my part. I'll fix it right now.

@LarFii LarFii reopened this Oct 26, 2024
@LarFii LarFii merged commit 21eaf76 into HKUDS:main Oct 26, 2024
1 check failed
@Yazington
Copy link
Contributor Author

was using ruff formatter I think might be reason why builds are failing

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants