-
Notifications
You must be signed in to change notification settings - Fork 183
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changed a relative text-only URL to a full URL in the NamingSystemIdentifierType codesystem #3205
base: master
Are you sure you want to change the base?
Conversation
Closes FHIR-42696.
why is this a good change? I believe it is a wrong change to make. And which committee authorised it? |
@grahamegrieve Sorry if I skipped a step, Grahame! I'm used to the UTG/Terminology procedures, where a PR is created before submitting an issue for review. The FHIR ticket associated with this change (https://jira.hl7.org/browse/FHIR-42696) has been triaged as Highest priority since last September, so I though that creating a PR for it might help people evaluate it and then decide if it's a worthwhile change or to reject it. I'll move this PR back into Draft status and -- if you'd like -- I could close it and/or delete it as well. As to why it is a good change, other entries on http://hl7.org/fhir/R5/codesystem-namingsystem-identifier-type.html use absolute URLs ( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This should be a hyperlink rather than just writing out the full URL.
Thanks, Lloyd! Do you have an example of what this should look like? I'm not sure how to insert a hypertext into a (I was also following the convention currently used by other definitions in this field, such as for |
Try: |
HL7 FHIR Pull Request
Note: No pull requests will be accepted against
./source
unless logged in the HL7 Jira issue tracker.If you made changes to any files within
./source
please indicate the Jira tracker number this pull request is associated with:FHIR-42696
Description
Please describe your pull request here.
As per FHIR-42696, this PR changes a relative text-only URL (rdf.html#iri-stem) to a full URL (http://hl7.org/fhir/rdf.html#iri-stem).