Compute path for axios #73
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
crpc
requested changes
Oct 13, 2023
| private generatePathFromNode(node: tsMorph.Node): string { | ||
| // simple string | ||
| if (node.getType().isStringLiteral()) { | ||
| return node.getType().getText().replace(/["']/g, ''); |
There was a problem hiding this comment.
' is a valid URL character, we cannot delete them here
src: https://stackoverflow.com/questions/1547899/which-characters-make-a-url-invalid/1547940#1547940
There was a problem hiding this comment.
Please fill in the docs with information about automatic retrieval of path when using @pact-axios.
Also probably not related to this change, but since we're not supporting axios.request(config) or axios(url, config) functions, it may be worth to include in the docs what axios methods we support
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #67
Additionaly this PR introduces baseURL which can be set in pacts.config.js. This option allows to set prefix path for all interactions.
It is heplful when you use baseURL from axios.