Support #3059 #3014: 允许关闭微软登录自动复制代码、允许关闭自动切换游戏语言 #3084
Conversation
There was a problem hiding this comment.
Overall it is pretty good. I built and tested it myself using the code from this branch. The former can not be tested because it is not an official build.
The latter feature works as expected. But there are some flaws in the interface. The latter’s text display length in the settings seems to be set according to the length of Chinese characters, but when displayed in English, part of the English text will be truncated.
How I discovered it: I tried removing the corresponding translation in the simplified Chinese language file, then building and running it.
Preview
Edit 1: I compared it again and found that the conclusion of the strikethrough part seemed incorrect, but the English text was indeed truncated.
Edit 2: It seems to have a lot to do with the font. Some fonts can display English text perfectly, but for most fonts, at least some of it will be truncated. Could you consider increasing the text display length appropriately?
| @@ -1167,7 +1167,7 @@ settings.launcher.theme=Theme | |||
| settings.launcher.title_transparent=Transparent titlebar | |||
| settings.launcher.turn_off_animations=Turn off animation (applies after restart) | |||
| settings.launcher.version_list_source=Version List | |||
| settings.launcher.auto_switch_game_language=Automatically switch game language (Simplified Chinese) | |||
| settings.launcher.auto_switch_game_language=Autoaticallym switch game language (Simplified Chinese) | |||
There was a problem hiding this comment.
| settings.launcher.auto_switch_game_language=Autoaticallym switch game language (Simplified Chinese) | |
| settings.launcher.auto_switch_game_language=Automatically switch game language (Simplified Chinese) |
|
如果这个 PR 通过了，记得将自动复制代码开关默认关闭 |
| import static org.jackhuang.hmcl.util.i18n.I18n.i18n; | ||
| import static org.jackhuang.hmcl.util.javafx.ExtendedProperties.selectedItemPropertyFor; | ||
|
|
||
| public class AccountPage extends StackPane { |
There was a problem hiding this comment.
不应当直接继承 StackPane，这与其他 HMCL 代码不统一。请参照其他地方的写法修改
For #3059：
在设置添加了新页面，增加了对应的选择框
For #3014：
在设置->通用页面添加了对应的选择框（仅在简体中文下才会显示）