Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update I18N.properties English Translations #3477

Merged
merged 9 commits into from
Jan 5, 2025

Conversation

lijiaxuan1811
Copy link
Contributor

更新了英文语言翻译文件,修复了一些语法错误并且让一些句子更加通顺

更新了英文语言翻译文件,修复了一些语法错误并且让一些句子更加通顺
Copy link
Contributor

@3gf8jv4dv 3gf8jv4dv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

大部分修订是不错的👍不过仍然有一些地方需要讨论。我晚些时候发。

@lijiaxuan1811
Copy link
Contributor Author

好的

HMCL/src/main/resources/assets/lang/I18N.properties Outdated Show resolved Hide resolved
HMCL/src/main/resources/assets/lang/I18N.properties Outdated Show resolved Hide resolved
HMCL/src/main/resources/assets/lang/I18N.properties Outdated Show resolved Hide resolved
HMCL/src/main/resources/assets/lang/I18N.properties Outdated Show resolved Hide resolved
HMCL/src/main/resources/assets/lang/I18N.properties Outdated Show resolved Hide resolved
HMCL/src/main/resources/assets/lang/I18N.properties Outdated Show resolved Hide resolved
lijiaxuan1811 and others added 4 commits November 29, 2024 10:00
Co-authored-by: 3gf8jv4dv <3gf8jv4dv@gmail.com>
Co-authored-by: 3gf8jv4dv <3gf8jv4dv@gmail.com>
Co-authored-by: 3gf8jv4dv <3gf8jv4dv@gmail.com>
Co-authored-by: 3gf8jv4dv <3gf8jv4dv@gmail.com>
@lijiaxuan1811
Copy link
Contributor Author

好的没问题 (您提出的建议非常好)

@3gf8jv4dv
Copy link
Contributor

#3477 (comment)
#3477 (comment)

这两个是忘记改了嘛?🤔

@lijiaxuan1811
Copy link
Contributor Author

没啊()我看你已经给改了?(😰)

@3gf8jv4dv
Copy link
Contributor

没啊()我看你已经给改了?(😰)

呃…… 你再仔细看看?

#3477 (comment)
#3477 (comment)

第一个需要你手动编辑,第二个你没应用。

@lijiaxuan1811
Copy link
Contributor Author

没啊()我看你已经给改了?(😰)

呃…… 你再仔细看看?

#3477 (comment) #3477 (comment)

第一个需要你手动编辑,第二个你没应用。

哎 真的很不好意思 我这边没看着()
现在改好了()😇

@3gf8jv4dv
Copy link
Contributor

哎 真的很不好意思 我这边没看着()
现在改好了()😇

没事(

Copy link
Contributor

@3gf8jv4dv 3gf8jv4dv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

再检查了下,剩余的几个意见。

EDIT: 删了一个不必要的意见。

HMCL/src/main/resources/assets/lang/I18N.properties Outdated Show resolved Hide resolved
HMCL/src/main/resources/assets/lang/I18N.properties Outdated Show resolved Hide resolved
lijiaxuan1811 and others added 2 commits November 29, 2024 12:21
Co-authored-by: 3gf8jv4dv <3gf8jv4dv@gmail.com>
Co-authored-by: 3gf8jv4dv <3gf8jv4dv@gmail.com>
@lijiaxuan1811
Copy link
Contributor Author

再检查了下,剩余的几个意见。

EDIT: 删了一个不必要的意见。

okok()
已经修改完毕()
非常感谢您的宝贵意见😄

Copy link
Contributor

@3gf8jv4dv 3gf8jv4dv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. It is ready now.

cc @Glavo

@3gf8jv4dv
Copy link
Contributor

cc @yushijinhun

@zkitefly zkitefly requested a review from yushijinhun January 5, 2025 10:31
@yushijinhun yushijinhun merged commit 662bf1a into HMCL-dev:main Jan 5, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants