Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

if only the scope column is visible in the navigation pane, there is no horizontal scroll bar #199

Closed
jmellorcrummey opened this issue May 16, 2022 · 0 comments
Closed

if only the scope column is visible in the navigation pane, there is no horizontal scroll bar #199

jmellorcrummey opened this issue May 16, 2022 · 0 comments
Assignees
@laksono
Labels
bug Something isn't working resolved Resolved, but need to be tested and confirmed
Milestone
Release 2022.06

Comments

@jmellorcrummey
Copy link
Member

jmellorcrummey commented May 16, 2022 •
edited
Loading

Describe the bug
On Linux, if you shrink the width of the window so that none of the metric columns are visible, the scroll bar disappears.

To Reproduce
Take any database with the 2022.03 viewer and shrink the width

Expected behavior
I think at least one metric should always be at least partially visible when the width of the hpcviewer window is shrunk.

Screenshots
image

Platform (please complete the following information):
Linux
x86
iris.cs
@jmellorcrummey jmellorcrummey added the bug Something isn't working label May 16, 2022
laksono pushed a commit that referenced this issue May 16, 2022
Fix issue #199 (no scroll bar when only the tree column is visible)
8928a24 
The root cause of this is because the scroll bar only appears if the
metric columns are also visible.
To ensure the scroll bar is visible, the width of tree column needs to
be adjusted to allow at least one metric column is visible.
@laksono laksono mentioned this issue May 17, 2022
Closed
@laksono laksono added the resolved Resolved, but need to be tested and confirmed label May 23, 2022
@laksono laksono added this to the Release 2022.04 milestone May 23, 2022
@laksono laksono closed this as completed May 23, 2022
laksono added a commit that referenced this issue May 30, 2022
@laksono
Refine fix issue #199 for high def screen
50e3408 
Update:
- The previous fix doesn't cater high def screen (mac book, windows) and
report incorrect size of the table.
- Reuse the pack method for both initial and resizing listener to avoid
duplicate code and ensure it uses the same pack algorithm.
@laksono laksono mentioned this issue May 31, 2022
Closed
laksono added a commit that referenced this issue May 31, 2022
@laksono
Refine issue #199 and resizing on Linux/GTK
ab683a6 
For unknown reason, on Linux/GTK it triggers resize event even though
the window's size doesn't change.
This fix will check manually if there's any changes with table size or
not.

Other fix: Make sure the width of tree column is static as much as
possible unless its width is bigger than the table's width.
laksono added a commit that referenced this issue Jun 1, 2022
@laksono
Refine fix issue #199: dispose the resizing listener
ac1f68f 
Otherwise it keeps intercepting the resizing event
laksono added a commit that referenced this issue Jun 1, 2022
@laksono
Refine fix for issue #199 specifically for high def screen
42b626f 
It turns out the output of bodyDataLayer.getColumnWidthByPosition has to
be converted to pixels although the doc says the unit is pixels.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@laksono laksono

Labels
bug Something isn't working resolved Resolved, but need to be tested and confirmed
Projects
None yet
Milestone
Release 2022.06
Development

No branches or pull requests
2 participants
@jmellorcrummey @laksono