Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Thread view: no exclusive costs #209

Closed
laksono opened this issue Jun 7, 2022 · 1 comment
Closed

Thread view: no exclusive costs #209

laksono opened this issue Jun 7, 2022 · 1 comment
Labels
bug Something isn't working resolved Resolved, but need to be tested and confirmed
Milestone
Release 2022.06

Comments

@laksono
Copy link
Member

laksono commented Jun 7, 2022

Describe the bug
The exclusive cost of thread view is empty

Screenshots
image
@laksono laksono added the bug Something isn't working label Jun 7, 2022
laksono added a commit that referenced this issue Jun 8, 2022
@laksono
Fix issue #209 (the root has no exclusive costs in the thread view)
a6670c1 
This happens because hpcprof doesn't generate exclusive costs for the
root.
The solution is the viewer has to copy the costs from the inclusive one.
However, this causes another problem: the original hpcprof doesn't
provide information of metric partner. At the moment the viewer only
assumes that if two metrics have the same name, they must be partnered.
@laksono laksono added this to the Release 2022.06 milestone Jun 8, 2022
@laksono
Copy link
Member Author

laksono commented Jun 8, 2022

Fixed in commit a6670c1
The problem is because hpcprof doesn't generate the root's exclusive costs in metric-db. Worse, the metric has no partner information so the viewer has to "guess" which metric is the partner, and grab the partner's value.

@laksono laksono closed this as completed Jun 8, 2022
@laksono laksono added the resolved Resolved, but need to be tested and confirmed label Jun 8, 2022
laksono added a commit that referenced this issue Jun 9, 2022
@laksono
Fix issue #209 (empty metrics in merge window)
b2ccf9c 
Avoid using empty metrics as criteria to merge the databases.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working resolved Resolved, but need to be tested and confirmed
Projects
None yet
Milestone
Release 2022.06
Development

No branches or pull requests
1 participant
@laksono