Refactor to modify x2l instead of atm2lnd #40
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For this to work, it was needed to - Switch oas_receive_icon() and lnd_import() - Store rain in "large scale" rainl, set "convective" rainc to zero - Store snow in "large scale" snowl, set "convective" snowc to zero - Removed redundant assignment to atm2lnd_inst%forc_solar_grc(:) - Enabled it again in case ICON in clm5/cpl/lnd_import_export.F90 - Enabled checks again for ICON in clm5/cpl/lnd_import_export.F90
The precompiled code from 'refac-x2l-incr' is now identical to the precompiled code from 'master'.
s-poll
approved these changes
Jul 15, 2024
|
@AGonzalezNicolas @kvrigor Can one of you merge the PR? Or are we allowed to merge it by our own? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Here
x2lis updated by ICON variables instead ofatm2lnd.It is strictly not a pure refactoring of the
mastercode, because the output is different. However, the output fromrefac-x2l-incris identical (in any output variables for any timestep) to that inmaster+vars+patch. The branchmaster+vars+patchis a (somewhat messy) bug fix tomasterwithout any refactoring. It is only meant as a proof of concept to show thatrefac-x2l-incris good to merge.