Fixes the number issue present on the App Registrations page. #9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
July 10, 2020 14:00
Haven't tested this code yet. Should fix the funny issue with the 1000k number display.
Did in the car and forgot that else doesnt also include the condition so
|
/cc @colmharte |
jasnell
added a commit
to jasnell/covid-tracker-app
that referenced
this pull request
Jul 28, 2020
colmharte
requested changes
Jul 30, 2020
| @@ -27,7 +27,7 @@ function formatLabel(value: number) { | |||
| return `${millions}m`; | |||
| } | |||
|
|
|||
| if (value > 1000) { | |||
| else if (value > 1000) { | |||
There was a problem hiding this comment.
Previous if statement returns from the function so changing this to an else if will not change the behaviour
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Basically moves an if from an else if. Was very bored in the car going around cork.