Move LHCb to use Draco and LHCb.glb #530
Conversation
|
Okay, comparing surge ( http://phoenix-pr-530.surge.sh/#/lhcb) vs normal (http://hepsoftwarefoundation.org/phoenix/#/lhcb) I see: So, I don't think it makes it any faster (at least on my very quick connection), but this means the overhead of decompressing isn't too bad (at least on my M1 Pro mac)... if my connection was slower, I can imagine it would help. So I'd be inclined to accept it.
|
|
You can check how to throttle network using Chrome DevTools and see how long it takes for the geometry to load on a slow network. I tried on the surge URL for PR but the application is throwing errors on slow network. The deployed version works fine. |
|
I confirm I see surge slightly slower on the CERN fast connection. No big news here and I agree we could merge. One thing though, don't you want to drop the old file ? Otherwise the gltf and the glb will quickly become out of sync. And the other missing bit is maybe the recipe for creating the glb form the gltf, for future updates |
|
I agree it's best to keep only one and that we should document the conversion! Looks very useful for slow connections, many thanks. |
|
Hi @sponce and @bencouturier - I removed the |
EdwardMoyse
force-pushed
the
master--draco
branch
from
c81cd0d to
6c1dc80
Compare
|
|
||
| const dracoLoader = new DRACOLoader(); | ||
| dracoLoader.setDecoderPath( | ||
| `https://cdn.jsdelivr.net/npm/three@0.${REVISION}.0/examples/js/libs/draco/` |
There was a problem hiding this comment.
I get now a failure in the LHCb deployment that this path gives a 404. In our case REVISION happens to be 148.0 and indeed the path is wrong for that version. "js/libs" should be replaced with "jsm".
@EdwardMoyse Do you understand why and why it does not fail for you ?
There was a problem hiding this comment.
I've just checked and your path is correct for 146... It seems things have changed on the threejs side !
There was a problem hiding this comment.
And here is the explanation : https://discourse.threejs.org/t/the-examples-js-directory-will-be-removed-with-r148/45349
There was a problem hiding this comment.
Right - updating threejs version is always a bit of work. Since phoenix is on 0.147.1 I would definitely not recommend moving your local deployment to something ahead of that. If you need it for some reason, we can prioritise updating phoenix.
There was a problem hiding this comment.
My issue is that we did not intend to move our local deployment. I have to check why we do not have the default 147. @bencouturier any idea ?
This migrates LHCb to compressed glb (generated with:
gltf-pipeline -i LHCb.gltf -o LHCb.glb -d)This reduces the size of the geometry from 19Mb to 7.2Mb
To uncompress the geometry, we need to add the
DRACOLoader(see the discussion in #529)In my local tests this doesn't really improve anything. However I would expect it might running remotely... however I need to test this (hopefully I can use the deployment here to do so).
cc @sponce