Remove hard-coded area-based bounds from Purpose
#459
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Introduce more general sub-bounds that can define separate parameters for arbitrary number of sub-regions instead of two
johpiip
previously approved these changes
Sep 13, 2022
johpiip
approved these changes
Sep 21, 2022
|
Everything seems good here, but I am not authorized to merge, @johpiip. |
Sorryyy, I did not realize! 😢 |
johpiip
added a commit
that referenced
this pull request
Sep 25, 2022
* Speed up histogram incrementation by changing lookup method (#452) * Fix floating-point number error (#455) * Fix bicycle trips CBA (#463) Fix incorrect linking of bicycle trips in CBA Excel sheet that causes travel time saving of leisure trips being calculated based on work trips data. * Remove hard-coded area-based bounds from `Purpose` (#459) * Remove hard-coded area-based bounds from `Purpose` Introduce more general sub-bounds that can define separate parameters for arbitrary number of sub-regions instead of two * Generalize transit trips per month accordingly * Add helpful comment Co-authored-by: Jens West <jens.west@hsl.fi> Co-authored-by: Sami Mäkinen <47142755+samakinen@users.noreply.github.com> Co-authored-by: Jens West <jens.west@traficom.fi>
johpiip
added a commit
that referenced
this pull request
Sep 25, 2022
* Fix/noise zones (#450) * Print nodes to better debug errors * Print 5 meter noise buffers for negative values * Set `cross_traffic` minimum value to 0.01 * Add error message * Revert zone width change Co-authored-by: Jens West <jens.west@hsl.fi> * Update `HELMET_VERSION` (#451) * Speed up histogram incrementation by changing lookup method (#452) * Fix floating-point number error (#455) * Fix bicycle trips CBA (#463) Fix incorrect linking of bicycle trips in CBA Excel sheet that causes travel time saving of leisure trips being calculated based on work trips data. * Remove hard-coded area-based bounds from `Purpose` (#459) * Remove hard-coded area-based bounds from `Purpose` Introduce more general sub-bounds that can define separate parameters for arbitrary number of sub-regions instead of two * Generalize transit trips per month accordingly * Add helpful comment Co-authored-by: Jens West <jens.west@hsl.fi> Co-authored-by: Sami Mäkinen <47142755+samakinen@users.noreply.github.com> Co-authored-by: Jens West <jens.west@traficom.fi>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduce more general sub-bounds that can define separate parameters for arbitrary number of sub-regions instead of two.