Skip to content

Commit

Permalink
Set the User-Agent regardless of GET or POST (jumbojett#382)
Browse files Browse the repository at this point in the history
  • Loading branch information
mig5 authored Aug 1, 2023
1 parent c146b71 commit 5d69bcf
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 1 deletion.
1 change: 1 addition & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,7 @@ The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/)
and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0.html).

## [unreleased]
* User-Agent is set for any HTTP method in fetchURL() (not just POST). #382
* Update visibility of getWellKnownConfigValue to protected. #363
* Fixed issue on authentication for php8. #354
* Support for signed and encrypted UserInfo response. #305
Expand Down
4 changes: 3 additions & 1 deletion src/OpenIDConnectClient.php
Original file line number Diff line number Diff line change
Expand Up @@ -1367,7 +1367,6 @@ protected function fetchURL(string $url, string $post_body = null, array $header
// Allows to keep the POST method even after redirect
curl_setopt($ch, CURLOPT_CUSTOMREQUEST, 'POST');
curl_setopt($ch, CURLOPT_POSTFIELDS, $post_body);
curl_setopt($ch, CURLOPT_USERAGENT, $this->getUserAgent());

// Default content type is form encoded
$content_type = 'application/x-www-form-urlencoded';
Expand All @@ -1381,6 +1380,9 @@ protected function fetchURL(string $url, string $post_body = null, array $header
$headers[] = "Content-Type: $content_type";
}

// Set the User-Agent
curl_setopt($ch, CURLOPT_USERAGENT, $this->getUserAgent());

// If we set some headers include them
if(count($headers) > 0) {
curl_setopt($ch, CURLOPT_HTTPHEADER, $headers);
Expand Down

0 comments on commit 5d69bcf

Please sign in to comment.