Skip to content

Commit

Permalink
Cahir.release fix (#66)
Browse files Browse the repository at this point in the history
* Fix: Release GHA was incorrect

* Correcting PR template
  • Loading branch information
cahirodoherty-learningpool authored Nov 30, 2023
1 parent 5ee0411 commit 4655309
Show file tree
Hide file tree
Showing 2 changed files with 14 additions and 20 deletions.
19 changes: 9 additions & 10 deletions .github/pull_request_template.md
Original file line number Diff line number Diff line change
@@ -1,24 +1,23 @@
<!-->Please title your PR according to eslint commit conventions</!-->
<!-->See https://github.com/conventional-changelog/conventional-changelog/tree/master/packages/conventional-changelog-eslint#eslint-convention for details</!-->
<!-->e.g. "Fix: Semi rule incorrectly flagging extra semicolon (fixes #840)"</!-->
<!-->or "Upgrade: Esprima to 1.2, switch to using comment attachment (fixes #730)"</!-->
[//]: # (Please title your PR according to eslint commit conventions)
[//]: # (See https://github.com/conventional-changelog/conventional-changelog/tree/master/packages/conventional-changelog-eslint#eslint-convention for details)

<!-->Link the PR to the original issue</!-->
fixes ADAPT-123
[//]: # (Link the PR to the original issue)

<!-->Delete Fix, New, Breaking sections as appropriate</!-->
[//]: # (Delete Fix, Update, New and/or Breaking sections as appropriate)
### Fix
* A sentence describing each fix

### Update
* A sentence describing each update

### New
* A sentence describing each new feature

### Breaking
* A sentence describing each breaking change

<!-->List appropriate steps for testing if needed</!-->
[//]: # (List appropriate steps for testing if needed)
### Testing
1. Steps for testing

<!-->Mention any other dependencies</!-->
requires ADAPT-456
[//]: # (Mention any other dependencies)
15 changes: 5 additions & 10 deletions .github/workflows/releases.yml → .github/workflows/release.yml
Original file line number Diff line number Diff line change
Expand Up @@ -12,23 +12,18 @@ jobs:
uses: actions/checkout@v3
with:
fetch-depth: 0
token: ${{ secrets.GITHUB_TOKEN }}
token: ${{ secrets.SEMANTIC_RELEASE_GITHUB_TOKEN }}

- name: Setup Node.js
uses: actions/setup-node@v3
with:
node-version: 'lts/*'
cache: 'npm'
cache: yarn

- name: Install dependencies
run: npm ci
run: yarn install --frozen-lockfile

- name: Release
env:
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
run: npm run semantic-release

permissions:
contents: write
pull-requests: write
issues: write
GITHUB_TOKEN: ${{ secrets.SEMANTIC_RELEASE_GITHUB_TOKEN }}
run: yarn semantic-release

0 comments on commit 4655309

Please sign in to comment.