Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cahir.release fix #66

Merged
merged 2 commits into from
Nov 30, 2023
Merged

Cahir.release fix #66

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2ca9450
Fix: Release GHA was incorrect
cahirodoherty-learningpool Nov 30, 2023
793c84d
Correcting PR template
cahirodoherty-learningpool Nov 30, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 9 additions & 10 deletions .github/pull_request_template.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,24 +1,23 @@
<!-->Please title your PR according to eslint commit conventions</!-->
<!-->See https://github.com/conventional-changelog/conventional-changelog/tree/master/packages/conventional-changelog-eslint#eslint-convention for details</!-->
<!-->e.g. "Fix: Semi rule incorrectly flagging extra semicolon (fixes #840)"</!-->
<!-->or "Upgrade: Esprima to 1.2, switch to using comment attachment (fixes #730)"</!-->
[//]: # (Please title your PR according to eslint commit conventions)
[//]: # (See https://github.com/conventional-changelog/conventional-changelog/tree/master/packages/conventional-changelog-eslint#eslint-convention for details)

<!-->Link the PR to the original issue</!-->
fixes ADAPT-123
[//]: # (Link the PR to the original issue)

<!-->Delete Fix, New, Breaking sections as appropriate</!-->
[//]: # (Delete Fix, Update, New and/or Breaking sections as appropriate)
### Fix
* A sentence describing each fix

### Update
* A sentence describing each update

### New
* A sentence describing each new feature

### Breaking
* A sentence describing each breaking change

<!-->List appropriate steps for testing if needed</!-->
[//]: # (List appropriate steps for testing if needed)
### Testing
1. Steps for testing

<!-->Mention any other dependencies</!-->
requires ADAPT-456
[//]: # (Mention any other dependencies)
15 changes: 5 additions & 10 deletions .github/workflows/releases.yml → .github/workflows/release.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,23 +12,18 @@ jobs:
uses: actions/checkout@v3
with:
fetch-depth: 0
token: ${{ secrets.GITHUB_TOKEN }}
token: ${{ secrets.SEMANTIC_RELEASE_GITHUB_TOKEN }}

- name: Setup Node.js
uses: actions/setup-node@v3
with:
node-version: 'lts/*'
cache: 'npm'
cache: yarn

- name: Install dependencies
run: npm ci
run: yarn install --frozen-lockfile

- name: Release
env:
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
run: npm run semantic-release

permissions:
contents: write
pull-requests: write
issues: write
GITHUB_TOKEN: ${{ secrets.SEMANTIC_RELEASE_GITHUB_TOKEN }}
run: yarn semantic-release