Create README.md #2
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* README.md updated. * initializing Functionality doc * Creditrisk functionality doc added
|
@chrizandr Please do merge this PR. |
chrizandr
approved these changes
Jun 15, 2021
Mec-iS
reviewed
Jun 15, 2021
| import pickle | ||
|
|
||
| API_Doc_file = open("creditrisk_poc/API_Doc/APIDOC","rb") | ||
| doc = pickle.load(API_Doc_file) |
There was a problem hiding this comment.
@Purvanshsingh why is this being merged? it is using the pickle serialisation that we agreed to change.
#3 should have been merged first and this one only after, please be more attentive
There was a problem hiding this comment.
@chrizandr this should have not been approved
There was a problem hiding this comment.
@Mec-iS I'll fix that now, it was a small change else everything was approved by phillipos that's why I merged.
There was a problem hiding this comment.
We had approved this on the call. I thought it was already reviewed by Phillipos as well.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.