-
-
Notifications
You must be signed in to change notification settings - Fork 171
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Performance 2020 #905
Comments
I am interested in the reviewers role for this topic - Phil |
I'm afraid I'm not fluent enough in English to create the content. I can help reviewing, though. |
@thefoxis thank you for agreeing to be the lead author for the Performance chapter! As the lead, you'll be responsible for driving the content planning and writing phases in collaboration with your content team, which will consist of yourself as lead, any coauthors you choose as needed, peer reviewers, and data analysts. The immediate next steps for this chapter are:
There's a ton of info in the top comment, so check that out and feel free to ping myself or @OBTo with any questions! To everyone else who has been nominated: @logicalphase we'd still love to have you contribute as a peer reviewer or coauthor as needed. Let us know if you're still interested! |
@dimension85 @borisschapira thank you! I've added you both as reviewers. |
I can also help out. |
Thanks Estelle! I've also added you as a reviewer. |
Excellent, thanks for adding me to the team - this is the first time I have been involved with this project and am looking forward to contributing. |
Would love to co-author this section. Please let me know if I can help. |
Happy to review again this year! |
An all-star team again this year. Really excited for this 🎉 |
On Wed, 1 Jul 2020 at 21:52 Rick Viscomi ***@***.***> wrote:
@thefoxis <https://github.com/thefoxis> thank you for agreeing to be the
lead author for the Performance chapter! As the lead, you'll be responsible
for driving the content planning and writing phases in collaboration with
your content team, which will consist of yourself as lead, any coauthors
you choose as needed, peer reviewers, and data analysts.
The immediate next steps for this chapter are:
1. Establish the rest of your content team. Several other people were
interested or nominated (see below), so that's a great place to start. The
larger the scope of the chapter, the more people you'll want to have on
board.
2. Start sketching out ideas in your draft doc
<https://docs.google.com/document/d/1EeUJ88PS8Ms9XUrNIpM2tpm5Ad_K682ZMVfc24TM02w/edit?usp=sharing>
.
3. Catch up on last year's chapter
<https://almanac.httparchive.org/en/2019/performance> and the project
methodology <https://almanac.httparchive.org/en/2019/methodology> to
get a sense for what's possible.
There's a ton of info in the top comment, so check that out and feel free
to ping myself or @OBTo <https://github.com/obto> with any questions!
To everyone else who has been nominated:
@HyperPress
@Zizzamia <https://github.com/Zizzamia>
@noamr <https://github.com/noamr>
@dimension85 <https://github.com/dimension85>
we'd still love to have you contribute as a peer reviewer or coauthor as
needed. Let us know if you're still interested!
Great! Would love to review.
… —
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#905 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAAVT5QSPOAQUHH4N2SRL4TRZOAYLANCNFSM4OJ2CP2A>
.
|
I would like to be a reviewer for this topic. |
Happy to join as a reviewer, looking forward to collaborate with the all Content team. 🌲 🚀 🌕 |
👋 hi everyone! thanks again @rviscomi and @OBTo for selecting me to lead this effort. looks like we have a solid team of reviewers but we're short on analysts. should we be looking for people swapping areas of responsibility or look for new people to join? I'm going to re-read last years chapter and reflect on what has happened in perf within the year. I think it'd be nice to speak to some new developments in the space, for example core web vitals or the shift in performance score algorithm. but it also depends on what sort of trends/data we're able to discover via the archive. I'll jot some notes down in the google doc within the next couple days. JavaScript is also always good to cover since it affects perf/UX greatly, so we could be looking at TBT & TTI. none of these were really covered last year so there would be no duplication (the previous report mentioned FID though, which is only relevant to people using RUM solutions/not Lighthouse). if anyone has any ideas/suggestions, I'm all 👂 |
@thefoxis yeah I agree 100% ! 🔥 Other points on top of my mind are:
What else? 🤔 That's it for now, but I am sure the rest of the team has more angles we could deep dive 🌲🚀🌕 |
@OBTo thank you for letting me know! I didn't see it. I doubt I can do this by Nov 9, I've been sick for the past week and still I am not well (fortunately, it's not covid 🤪 ) so it delays my ability to write a bit. that being said, I shouldn't need a lot of time to produce a draft, I'll post here once it's ready 👍 |
Sounds great, hope you feel better! |
@thefoxis get well soon! |
@OBTo @rviscomi I'll have a complete draft ready sometime next week. there's a bit more to be written than I initially expected. of course, you can keep an eye on the draft in the doc, as I'm writing directly there. @max-ostapenko @dooman87 I'd appreciate some help with the charts, since some are only representing a single metric versus complete readings and my spreadsheet skills turn out to fall a bit short here 😅 I'm going off the 2019 almanac, so the charts for each metric are:
The connection type chart wasn't portraying quite what I wanted (as per 2019 chapter), I tried playing with it, but didn't go far. This is what I'd love to have for each metric: I'm not entirely sure how to generate the charts for geo + device for other metrics than LCP so if you could point me in the right direction or help out here, that'd be great 😸 |
Hi @thefoxis I'm excited to see this coming along! I'm also happy to help with the data viz, feel free to @ me on whichever charts you'd like help with. |
@thefoxis As per your question: please check the chart here, if I understood you correctly: https://docs.google.com/spreadsheets/d/164FVuCQ7gPhTWUXJl1av5_hBxjncNi0TK8RnNseNPJQ/edit#gid=306222260 I'll appreciate if we can jump to sheet comments for exported results discussion. Please add comments on what needs adjustments and if any visualisations are missing. |
@rviscomi can you point me to the CrUX's categorisations of |
@thefoxis the thresholds used by CrUX for the CWV are defined at https://web.dev/vitals/#core-web-vitals We could also edit the legends of the charts to say something like "Good (<100ms)" and "Poor (>=300ms)". |
FCP and TTFB are more subjective and don't have official documentation. For reference the thresholds used by CrUX for fast/slow are: FCP: 1.5s, 2.5s |
A quick word to say that I'm starting the review and posting comments on the doc. |
@borisschapira no sweat 🙂 English is my second language too and the Poles are apparently also very direct so I know what you mean. any feedback appreciated! I already responded / acted on some of your comments. all good finds 👍 thank you! ⚡ |
Thanks for looking at my comments @thefoxis! I had a small nitpick with CLS, and ended up reading the whole chapter because it was such a good read. Really well written all round 💯 |
Thanks for the review @exterkamp. Could you add yourself to the contributors list? (alphabetical by first name) |
A great read! I'm reviewing the material now, prepare for some comments :) |
thanks @noamr and @exterkamp! good comments all around, I’m addressing it along @rviscomi’s feedback :) a few more bits to go, but I can see the end now 🎉 glad you enjoyed reading so far! |
@OBTo @rviscomi I believe I addressed all existing feedback and added a conclusion. FYI I removed captions since I figured with the markdown format I'll just submit them with the PR; let me know if that's suitable. feeling pretty good about it! let me know if there's anything else. @dimension85 @borisschapira @estelle @zeman @rviscomi @OBTo @noamr @ashrith-kulai @Zizzamia @exterkamp if you'd like to add any more/first thoughts to the draft, you're welcome to. I'm not sure how much ability I will have to address big shifts in content, but fixes / clarifications / smaller suggestions shouldn't be an issue with the schedule I reckon 😅 |
@thefoxis Sounds like a solid plan to me. I'll look at it again this evening to see if I pick up on anything before we start the editing process :) |
@thefoxis I'm excited to see this moving along! Thank you for your hard work getting it to this point. Can you open a PR to submit the markdown version of the draft? (the final milestone in the initial checklist) I've stubbed out the markdown file already with some early metadata and you can see the 2019 version for reference. I'm happy to help convert the data viz to the correct figure format, if you leave them as TODOs/placeholders in the markdown file. Please also update the chapter metadata to remove anyone who hasn't contributed, add your bio, add features quote/stats, etc. |
@thefoxis Just finished reading the chapter and quite enjoyed it. Great job. Just had a few small questions and suggestions I left in the Google Doc :) |
Part II Chapter 9: Performance
Content team
Content team lead: @thefoxis
Welcome chapter contributors! You'll be using this issue throughout the chapter lifecycle to coordinate on the content planning, analysis, and writing stages.
The content team is made up of the following contributors:
New contributors: If you're interested in joining the content team for this chapter, just leave a comment below and the content team lead will loop you in.
Note: To ensure that you get notifications when tagged, you must be "watching" this repository.
Milestones
0. Form the content team
1. Plan content
2. Gather data
3. Validate results
4. Draft content
5. Publication
The text was updated successfully, but these errors were encountered: