Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Page Weight 2020 SQL queries #1349

Merged
merged 6 commits into from
Nov 5, 2020
Merged

Page Weight 2020 SQL queries #1349

merged 6 commits into from
Nov 5, 2020

Conversation

paulcalvano
Copy link
Contributor

@paulcalvano paulcalvano commented Oct 6, 2020

Progress on #919

I've updated the Page Weight queries used in 2019, and saved the results in this Google sheet. Also added some visualizations.

https://docs.google.com/spreadsheets/d/1wG4u0LV5PT9aN-XB1hixSFtI8KIDARTOCX0sp7ZT3h0/edit?usp=sharing

I may add some more queries after talking with @henrihelvetica .

Paul

@rviscomi rviscomi added the analysis Querying the dataset label Oct 6, 2020
@rviscomi rviscomi added this to the 2020 Analysis milestone Oct 6, 2020
sql/2020/18_Page_Weight/18_01.sql Outdated Show resolved Hide resolved
sql/2020/18_Page_Weight/18_01b.sql Outdated Show resolved Hide resolved
sql/2020/18_Page_Weight/18_01.sql Outdated Show resolved Hide resolved
@rviscomi rviscomi added the ASAP This issue is blocking progress label Oct 15, 2020
Copy link
Member

@rviscomi rviscomi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one nit on the file naming. This would make it easier to browse the queries in a directory and avoid confusion with sequentially numbered figures. The tab names in the results spreadsheet should also use this naming scheme.

sql/2020/18_Page_Weight/18_01.sql Outdated Show resolved Hide resolved
@foxdavidj
Copy link
Contributor

Looks like this is coming along nicely. How can we get this merged by the end of the week?

@rviscomi rviscomi merged commit 0df7711 into main Nov 5, 2020
@rviscomi rviscomi deleted the page-weight-sql-2020 branch November 5, 2020 15:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
analysis Querying the dataset ASAP This issue is blocking progress
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants