-
-
Notifications
You must be signed in to change notification settings - Fork 171
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Security SQL: final queries #1534
Conversation
I'm guessing that the failed checks are unrelated to this particular pull request? The reported error is:
|
Just merged a fix (#1535) into |
Yep, that fixed it 👍 |
Co-authored-by: Barry Pollard <barry_pollard@hotmail.com>
@tomvangoethem please see @bazzadp's feedback. We should merge this ASAP. |
Will fix it tomorrow! |
Updated cryptominer query. However, as @bazzadp mentioned, the number looks very low. Looking into that right now. |
Coinhive: shut down From the paper "Is Cryptojacking Dead after Coinhive Shutdown?":
So it seems that cryptojacking is not financially viable any more (because of hard fork that caused a 50+% drop in hash rate, and the drop in value of XMR), which makes me think that the results are more or less representative |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. A few very minor nits.
This good to merge?
Yep, good to merge I think. That should be it for Security SQL 🥳 |
Great stuff. Now just to write the thing 😁 |
Progress on #906