Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Security SQL 2020: fix version evolution top technologies query #1650

Merged
merged 1 commit into from
Dec 6, 2020

Conversation

tomvangoethem
Copy link
Contributor

@tomvangoethem tomvangoethem commented Dec 6, 2020

Two things were wrong with the query:

  1. the category column in technologies contained both upper and lower case versions of the same thing (e.g. Web server and Web Server); I made it lowercase, so that should fix that. Did the same with app as a precaution.
  2. month was not part of the partition in the OVER BY causing many versions to report lower numbers

Part of #906

@tunetheweb tunetheweb added the analysis Querying the dataset label Dec 6, 2020
@tunetheweb tunetheweb added this to the 2020 Analysis milestone Dec 6, 2020
@tunetheweb tunetheweb merged commit 38c3d0f into main Dec 6, 2020
@tunetheweb tunetheweb deleted the security-sql-2020 branch December 6, 2020 22:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
analysis Querying the dataset
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants