Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Security 2020: markdown content #1663

Merged
merged 21 commits into from
Dec 9, 2020
Merged

Security 2020: markdown content #1663

merged 21 commits into from
Dec 9, 2020

Conversation

tomvangoethem
Copy link
Contributor

Progress for #906

@rviscomi rviscomi added the writing Related to wording and content label Dec 7, 2020
@rviscomi rviscomi added this to the 2020 Content Writing milestone Dec 7, 2020
@rviscomi rviscomi added the ASAP This issue is blocking progress label Dec 8, 2020
@rviscomi rviscomi marked this pull request as ready for review December 8, 2020 20:18
@rviscomi
Copy link
Member

rviscomi commented Dec 8, 2020

@tomvangoethem what are the remaining action items before you're comfortable publishing this? I see a few TODOs but would you be ok launching without them?

@tomvangoethem
Copy link
Contributor Author

tomvangoethem commented Dec 8, 2020 •
edited by tunetheweb
Loading

The placeholders for the images still need to be updated (@bazzadp said he'll be doing that). For the rest it's mainly copyediting I think.
I'm fine with launching once the images are there. (would be nice to have someone still look over the newly added text: such as introduction and conclusion)

@rviscomi
Copy link
Member

rviscomi commented Dec 8, 2020

Sounds great, thank you to the whole team for getting this ready for launch!

@tunetheweb
Copy link
Member

I’ve uploaded the figures and done a round of editing on most of it down to line 729 (Security mechanism adoption). I'd like to finish some more editing tomorrow but will merge this now and open a new PR for that.

I’ve staged the current version here: https://20201209t033020-dot-webalmanac.uk.r.appspot.com/en/2020/security.

@tunetheweb tunetheweb merged commit 19f225f into main Dec 9, 2020
@tunetheweb tunetheweb deleted the security-2020-markdown branch December 9, 2020 03:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rviscomi rviscomi rviscomi left review comments

@tunetheweb tunetheweb tunetheweb left review comments

@nrllh nrllh Awaiting requested review from nrllh

@cqueern cqueern Awaiting requested review from cqueern

@edmondwwchan edmondwwchan Awaiting requested review from edmondwwchan

Assignees

@tomvangoethem tomvangoethem

@tunetheweb tunetheweb

@nrllh nrllh

Labels
ASAP This issue is blocking progress writing Related to wording and content
Projects
None yet
Milestone
2020 Content Writing
Development

Successfully merging this pull request may close these issues.
4 participants
@tomvangoethem @rviscomi @tunetheweb @nrllh