Jamstack 2021 queries #2349
Merged
Jamstack 2021 queries #2349
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rviscomi
reviewed
Sep 28, 2021
|
Hi @denar90 just checking in on your progress. Is there anything I can do to help? |
|
@denar90 how's it going? |
Co-authored-by: Rick Viscomi <rviscomi@users.noreply.github.com>
|
Testing queries... |
|
@rviscomi I've aligned queries to use July data. |
rviscomi
requested changes
Oct 17, 2021
sql/2021/jamstack/ranking.sql
Outdated
| app, | ||
| COUNT(DISTINCT url) AS pages, | ||
| total_pages, | ||
| COUNT(DISTINCT url) / total_pages AS pct, |
There was a problem hiding this comment.
I think the denominator here should be the number of pages for the given rank, not all pages in the dataset.
There was a problem hiding this comment.
@denar90 have you had a chance to look into this?
Co-authored-by: Rick Viscomi <rviscomi@users.noreply.github.com>
Co-authored-by: Rick Viscomi <rviscomi@users.noreply.github.com>
Co-authored-by: Rick Viscomi <rviscomi@users.noreply.github.com>
|
Hi @denar90 this PR is close to merging. Can you take a look at the remaining review comments? |
Co-authored-by: Rick Viscomi <rviscomi@users.noreply.github.com>
rviscomi
approved these changes
Nov 2, 2021
|
@rviscomi thank you for the review 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Queries for #2156
These are most of queries from 2020
I have to run them again to see if we can add anything.