Update Compression 2021 contributors #2495
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rviscomi
added
writing
rviscomi
commented
Nov 14, 2021
src/content/en/2021/compression.md
Outdated
Comment on lines
5
to
7
| authors: [lvandeve] | ||
| reviewers: [] | ||
| analysts: [] |
There was a problem hiding this comment.
@lvandeve can you suggest edits to the Authors, Reviewers, and Analysts properties so that they contain everyone who contributed to the chapter, roughly ordered by those with the most significant contributions first? This is what readers will see at the top of the chapter so we want to be sure to give appropriate credit to everyone who helped.
There was a problem hiding this comment.
Done, I've added the suggestion, there is one more person with significant review I'd like to add whose github username I need to check
There was a problem hiding this comment.
Added the extra reviewer as well now by editing the original suggestion
There was a problem hiding this comment.
Ok thanks I'll add them in another PR
lvandeve
reviewed
Nov 16, 2021
Co-authored-by: Lode Vandevenne <lvandeve@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Progress on #2160