Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Markup 2021 edits #2643

Merged
merged 3 commits into from
Dec 1, 2021
Merged

Markup 2021 edits #2643

merged 3 commits into from
Dec 1, 2021

Conversation

rviscomi
Copy link
Member

@rviscomi rviscomi commented Dec 1, 2021

Closes #2142
Progress on #2525

Edits made in this PR:

  • Change markdown links to markup when they don't have a language code in them
  • Oxford comma
  • Rounding to one decimal place
  • Typos and grammar fixes

I did leave a couple of TODOs in the file which I'll flag for @AlexLakatos but I don't consider them blocking to merge this PR so that we can release this chapter in an edited state.

@rviscomi rviscomi added the editing Content excellence label Dec 1, 2021
@rviscomi rviscomi added this to the 2021 Launch 🚀 milestone Dec 1, 2021
This year, we wanted to take a look at SVG usage. With popular icon libraries using more and more SVG, favicon support improving and SVG images being on the rise in animations, it's no surprise 46% of web pages had some sort of SVG on them. 37% had a SVG element, 20.04% on desktop and 18.44% on mobile were using SVG images, and a negligible amount had either SVG embeds, objects or iframes in them.
This year, we wanted to take a look at SVG usage. With popular icon libraries using more and more SVG, favicon support improving, and SVG images being on the rise in animations, it's no surprise that 46.4% of web pages had some sort of SVG on them. 37.2% had a SVG element, 20.0% on desktop and 18.4% on mobile were using SVG images, and a negligible amount had either SVG embeds, objects, or iframes in them.

{# TODO: One or more of the stats above could use a big number figure. #}
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@@ -211,9 +209,11 @@ No need to panic, the web isn't all made up of divs. The median page uses 31 dif
sql_file="element_count_distribution.sql"
) }}

{# TODO: This figure isn't discussed. #}
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@tunetheweb
Copy link
Member

Ah rubbish. Didn't realise this wasn't merged yet and made some edits myself to fix the build :-(

@rviscomi rviscomi merged commit e0b07dd into main Dec 1, 2021
@rviscomi rviscomi deleted the markup-2021-edits branch December 1, 2021 13:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
editing Content excellence
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Markup 2021
2 participants