Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HTTP/2 chapter edits #359

Merged
merged 3 commits into from
Nov 7, 2019
Merged

HTTP/2 chapter edits #359

merged 3 commits into from
Nov 7, 2019

Conversation

rviscomi
Copy link
Member

@rviscomi rviscomi commented Nov 7, 2019

This is a branch of @rachellcostello's PR #334 including all of my copyedits and data viz changes.

@rviscomi rviscomi added the writing Related to wording and content label Nov 7, 2019
@rviscomi rviscomi added this to the SHIP IT! milestone Nov 7, 2019
@rviscomi
Copy link
Member Author

rviscomi commented Nov 7, 2019

@bazzadp I want to reiterate that this is an awesome chapter! I love the level of depth and passion you bring to the content. Great work!!

@tunetheweb
Copy link
Member

tunetheweb commented Nov 7, 2019

@bazzadp I want to reiterate that this is an awesome chapter! I love the level of depth and passion you bring to the content. Great work!!

That kind of buttering up can only mean you’ve ripped it to shreds in your editing 😀

Will take a look.

Copy link
Member

@tunetheweb tunetheweb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You were much kinder than I thought you'd be @rviscomi ! Happy to merge this, though can you look at the two comments?

@rviscomi can you also have a look at the outstandig comments in #334 and see if you have an opinion on them?

src/content/en/2019/http2.md Show resolved Hide resolved
src/content/en/2019/http2.md Outdated Show resolved Hide resolved
rviscomi and others added 2 commits November 7, 2019 09:45
Co-Authored-By: Barry Pollard <barry_pollard@hotmail.com>
@rviscomi rviscomi merged commit 72e872e into rachellcostello-patch-3 Nov 7, 2019
@rviscomi rviscomi deleted the rviscomi-edits branch November 7, 2019 17:59
rviscomi pushed a commit that referenced this pull request Nov 7, 2019
* Copyediting of the HTTP/2 Chapter

I've made some amends of the copy in this chapter, mainly for readability.

* Update src/content/en/2019/http2.md

Co-Authored-By: Barry Pollard <barry_pollard@hotmail.com>

* Update src/content/en/2019/http2.md

Co-Authored-By: Barry Pollard <barry_pollard@hotmail.com>

* Update src/content/en/2019/http2.md

Co-Authored-By: Barry Pollard <barry_pollard@hotmail.com>

* Update src/content/en/2019/http2.md

Co-Authored-By: Barry Pollard <barry_pollard@hotmail.com>

* Update src/content/en/2019/http2.md

Co-Authored-By: Barry Pollard <barry_pollard@hotmail.com>

* Update src/content/en/2019/http2.md

Co-Authored-By: Barry Pollard <barry_pollard@hotmail.com>

* Update src/content/en/2019/http2.md

* HTTP/2 chapter edits (#359)

* rick's edits

* Update src/content/en/2019/http2.md

Co-Authored-By: Barry Pollard <barry_pollard@hotmail.com>

* feedback

* Update src/content/en/2019/http2.md

Co-Authored-By: Barry Pollard <barry_pollard@hotmail.com>

* Update src/content/en/2019/http2.md

Co-Authored-By: Barry Pollard <barry_pollard@hotmail.com>

* Update src/content/en/2019/http2.md

Co-Authored-By: Barry Pollard <barry_pollard@hotmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
writing Related to wording and content
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants