Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix extra paragraph tags (simple fix) #414

Closed
wants to merge 5 commits into from
Closed

Fix extra paragraph tags (simple fix) #414

wants to merge 5 commits into from

Conversation

tunetheweb
Copy link
Member

@tunetheweb tunetheweb commented Nov 10, 2019 •
edited
Loading

Simple fix for #412 (proper fix to follow possibly).

@mikegeyser
Copy link
Contributor

I've pushed virtually the same fix to the extra-p-tags branch, except that it is in a separate script file. Could we go with that, or is it unnecessary? (Just checking, was about to open a PR.)

@github-actions
Copy link
Contributor

Images automagically compressed by Calibre's image-actions ✨

Compression reduced images by 52.4%, saving 68.27 KB

Filename Before After Improvement
src/static/images/2019/07_Performance/fig9.png 130.34 KB 62.07 KB -52.4%
Some images were already optimised
  • src/static/images/2019/01_JavaScript/fig1.png
  • src/static/images/2019/01_JavaScript/fig10.png
  • src/static/images/2019/01_JavaScript/fig12.png
  • src/static/images/2019/01_JavaScript/fig13.png
  • src/static/images/2019/01_JavaScript/fig14.png
  • src/static/images/2019/01_JavaScript/fig15.png
  • src/static/images/2019/01_JavaScript/fig16.png
  • src/static/images/2019/01_JavaScript/fig17.png
  • src/static/images/2019/01_JavaScript/fig18.png
  • src/static/images/2019/01_JavaScript/fig2.png
  • src/static/images/2019/01_JavaScript/fig3.png
  • src/static/images/2019/01_JavaScript/fig5.png
  • src/static/images/2019/01_JavaScript/fig6.png
  • src/static/images/2019/01_JavaScript/fig7.png
  • src/static/images/2019/01_JavaScript/fig8.png
  • src/static/images/2019/01_JavaScript/fig9.png
  • src/static/images/2019/01_JavaScript/hero_lg.jpg
  • src/static/images/2019/01_JavaScript/hero_sm.jpg
  • src/static/images/2019/01_JavaScript/hero_xl.jpg
  • src/static/images/2019/01_JavaScript/js-processing-reddit.png
  • src/static/images/2019/02_CSS/hero_lg.jpg
  • src/static/images/2019/02_CSS/hero_sm.jpg
  • src/static/images/2019/02_CSS/hero_xl.jpg
  • src/static/images/2019/03_Markup/element_categories.png
  • src/static/images/2019/03_Markup/hero_lg.jpg
  • src/static/images/2019/03_Markup/hero_sm.jpg
  • src/static/images/2019/03_Markup/hero_xl.jpg
  • src/static/images/2019/03_Markup/hixie_element_types_per_page.png
  • src/static/images/2019/03_Markup/hixie_elements_per_page.png
  • src/static/images/2019/04_Media/hero_lg.jpg
  • src/static/images/2019/04_Media/hero_sm.jpg
  • src/static/images/2019/04_Media/hero_xl.jpg
  • src/static/images/2019/05_Third_Parties/hero_lg.jpg
  • src/static/images/2019/05_Third_Parties/hero_sm.jpg
  • src/static/images/2019/05_Third_Parties/hero_xl.jpg
  • src/static/images/2019/06_Fonts/hero_lg.jpg
  • src/static/images/2019/06_Fonts/hero_sm.jpg
  • src/static/images/2019/06_Fonts/hero_xl.jpg
  • src/static/images/2019/07_Performance/fig1.png
  • src/static/images/2019/07_Performance/fig10.png
  • src/static/images/2019/07_Performance/fig11.png
  • src/static/images/2019/07_Performance/fig12.png
  • src/static/images/2019/07_Performance/fig13.png
  • src/static/images/2019/07_Performance/fig14.png
  • src/static/images/2019/07_Performance/fig15.png
  • src/static/images/2019/07_Performance/fig16.png
  • src/static/images/2019/07_Performance/fig17.png
  • src/static/images/2019/07_Performance/fig18.png
  • src/static/images/2019/07_Performance/fig2.png
  • src/static/images/2019/07_Performance/fig3.png
  • src/static/images/2019/07_Performance/fig4.png
  • src/static/images/2019/07_Performance/fig5.png
  • src/static/images/2019/07_Performance/fig6.png
  • src/static/images/2019/07_Performance/fig7.png
  • src/static/images/2019/07_Performance/fig8.png
  • src/static/images/2019/07_Performance/hero_lg.jpg
  • src/static/images/2019/07_Performance/hero_sm.jpg
  • src/static/images/2019/07_Performance/hero_xl.jpg
  • src/static/images/2019/07_Performance/nav-timing.png
  • src/static/images/2019/08_Security/hero_lg.jpg
  • src/static/images/2019/08_Security/hero_sm.jpg
  • src/static/images/2019/08_Security/hero_xl.jpg
  • src/static/images/2019/09_Accessibility/example-of-a-skip-link-on-google.com.png
  • src/static/images/2019/09_Accessibility/example-of-good-and-bad-color-contrast-lookzook.png
  • src/static/images/2019/09_Accessibility/hero_lg.jpg
  • src/static/images/2019/09_Accessibility/hero_sm.jpg
  • src/static/images/2019/09_Accessibility/hero_xl.jpg
  • src/static/images/2019/10_SEO/hero_lg.jpg
  • src/static/images/2019/10_SEO/hero_sm.jpg
  • src/static/images/2019/10_SEO/hero_xl.jpg
  • src/static/images/2019/11_PWA/hero_lg.jpg
  • src/static/images/2019/11_PWA/hero_sm.jpg
  • src/static/images/2019/11_PWA/hero_xl.jpg
  • src/static/images/2019/12_Mobile_Web/america-online-1000-hours-free.jpg
  • src/static/images/2019/12_Mobile_Web/example-of-easy-to-hit-tap-targets-lookzook.png
  • src/static/images/2019/12_Mobile_Web/example-of-good-and-bad-color-contrast-lookzook.png
  • src/static/images/2019/12_Mobile_Web/hero_lg.jpg
  • src/static/images/2019/12_Mobile_Web/hero_sm.jpg
  • src/static/images/2019/12_Mobile_Web/hero_xl.jpg
  • src/static/images/2019/13_Ecommerce/fig11.png
  • src/static/images/2019/13_Ecommerce/fig12.png
  • src/static/images/2019/13_Ecommerce/fig13.png
  • src/static/images/2019/13_Ecommerce/fig15.png
  • src/static/images/2019/13_Ecommerce/fig17.png
  • src/static/images/2019/13_Ecommerce/fig18.png
  • src/static/images/2019/13_Ecommerce/fig19.png
  • src/static/images/2019/13_Ecommerce/fig20.png
  • src/static/images/2019/13_Ecommerce/fig21.png
  • src/static/images/2019/13_Ecommerce/fig22.png
  • src/static/images/2019/13_Ecommerce/fig4.png
  • src/static/images/2019/13_Ecommerce/fig5.png
  • src/static/images/2019/13_Ecommerce/fig6.png
  • src/static/images/2019/13_Ecommerce/fig7.png
  • src/static/images/2019/13_Ecommerce/fig8.png
  • src/static/images/2019/13_Ecommerce/hero_lg.jpg
  • src/static/images/2019/13_Ecommerce/hero_sm.jpg
  • src/static/images/2019/13_Ecommerce/hero_xl.jpg
  • src/static/images/2019/14_CMS/cms-logos.png
  • src/static/images/2019/14_CMS/fig10.png
  • src/static/images/2019/14_CMS/fig11.png
  • src/static/images/2019/14_CMS/fig12.png
  • src/static/images/2019/14_CMS/fig14.png
  • src/static/images/2019/14_CMS/fig16.png
  • src/static/images/2019/14_CMS/fig18.png
  • src/static/images/2019/14_CMS/fig20.png
  • src/static/images/2019/14_CMS/fig21.png
  • src/static/images/2019/14_CMS/fig22.png
  • src/static/images/2019/14_CMS/fig23.png
  • src/static/images/2019/14_CMS/fig4.png
  • src/static/images/2019/14_CMS/fig5.png
  • src/static/images/2019/14_CMS/fig6.png
  • src/static/images/2019/14_CMS/fig7.png
  • src/static/images/2019/14_CMS/hero_lg.jpg
  • src/static/images/2019/14_CMS/hero_sm.jpg
  • src/static/images/2019/14_CMS/hero_xl.jpg
  • src/static/images/2019/14_CMS/perf-perception.png
  • src/static/images/2019/14_CMS/web-evolution.png
  • src/static/images/2019/15_Compression/ch15_fig10_lighthouse_compression_byte_savings.jpg
  • src/static/images/2019/15_Compression/ch15_fig2_compressed_content_types.jpg
  • src/static/images/2019/15_Compression/ch15_fig3_compressed_content_types_filtered.jpg
  • src/static/images/2019/15_Compression/ch15_fig4_compression_by_content_type_desktop.jpg
  • src/static/images/2019/15_Compression/ch15_fig5_compression_by_content_type_mobile.jpg
  • src/static/images/2019/15_Compression/ch15_fig6_compression_by_content_type_pct_desktop.jpg
  • src/static/images/2019/15_Compression/ch15_fig7_compression_by_content_type_pct_mobile.jpg
  • src/static/images/2019/15_Compression/ch15_fig8_lighthouse.jpg
  • src/static/images/2019/15_Compression/ch15_fig9_lighthouse_compression_scores.jpg
  • src/static/images/2019/15_Compression/fig2.png
  • src/static/images/2019/15_Compression/hero_lg.jpg
  • src/static/images/2019/15_Compression/hero_sm.jpg
  • src/static/images/2019/15_Compression/hero_xl.jpg
  • src/static/images/2019/16_Caching/ch16_fig1_redbot_example.jpg
  • src/static/images/2019/16_Caching/ch16_fig12_header_example_with_cookie.jpg
  • src/static/images/2019/16_Caching/ch16_fig13_cookies_on_cacheable_responses.jpg
  • src/static/images/2019/16_Caching/ch16_fig14_service_worker_adoption.jpg
  • src/static/images/2019/16_Caching/ch16_fig15_lighthouse_example.jpg
  • src/static/images/2019/16_Caching/ch16_fig8_resource_age.jpg
  • src/static/images/2019/16_Caching/fig12.png
  • src/static/images/2019/16_Caching/fig13.png
  • src/static/images/2019/16_Caching/fig14.png
  • src/static/images/2019/16_Caching/fig2.png
  • src/static/images/2019/16_Caching/fig21.png
  • src/static/images/2019/16_Caching/fig22.png
  • src/static/images/2019/16_Caching/fig3.png
  • src/static/images/2019/16_Caching/fig5.png
  • src/static/images/2019/16_Caching/fig6.png
  • src/static/images/2019/16_Caching/fig7.png
  • src/static/images/2019/16_Caching/fig9.png
  • src/static/images/2019/16_Caching/hero_lg.jpg
  • src/static/images/2019/16_Caching/hero_sm.jpg
  • src/static/images/2019/16_Caching/hero_xl.jpg
  • src/static/images/2019/17_CDN/hero_lg.jpg
  • src/static/images/2019/17_CDN/hero_sm.jpg
  • src/static/images/2019/17_CDN/hero_xl.jpg
  • src/static/images/2019/18_Page_Weight/ch18_fig1_conversion_difference.png
  • src/static/images/2019/18_Page_Weight/ch18_fig2_conversion_graph.png
  • src/static/images/2019/18_Page_Weight/ch18_fig3_gif_cdf.png
  • src/static/images/2019/18_Page_Weight/hero_lg.jpg
  • src/static/images/2019/18_Page_Weight/hero_sm.jpg
  • src/static/images/2019/18_Page_Weight/hero_xl.jpg
  • src/static/images/2019/19_Resource_Hints/hero_lg.jpg
  • src/static/images/2019/19_Resource_Hints/hero_sm.jpg
  • src/static/images/2019/19_Resource_Hints/hero_xl.jpg
  • src/static/images/2019/20_HTTP_2/ch20_fig10_total_requests_per_page_trend_over_years.png
  • src/static/images/2019/20_HTTP_2/ch20_fig13_what_push_is_used_for.png
  • src/static/images/2019/20_HTTP_2/ch20_fig2_http2_usage_by_request.png
  • src/static/images/2019/20_HTTP_2/ch20_fig9_num_tcp_connections_trend_over_years.png
  • src/static/images/2019/20_HTTP_2/hero_lg.jpg
  • src/static/images/2019/20_HTTP_2/hero_sm.jpg
  • src/static/images/2019/20_HTTP_2/hero_xl.jpg
  • src/static/images/avatars/0.jpg
  • src/static/images/avatars/1.jpg
  • src/static/images/avatars/10.jpg
  • src/static/images/avatars/11.jpg
  • src/static/images/avatars/12.jpg
  • src/static/images/avatars/13.jpg
  • src/static/images/avatars/14.jpg
  • src/static/images/avatars/2.jpg
  • src/static/images/avatars/3.jpg
  • src/static/images/avatars/4.jpg
  • src/static/images/avatars/5.jpg
  • src/static/images/avatars/6.jpg
  • src/static/images/avatars/7.jpg
  • src/static/images/avatars/8.jpg
  • src/static/images/avatars/9.jpg
  • src/static/images/blog.png
  • src/static/images/character-file.png
  • src/static/images/character-hat.png
  • src/static/images/character-markup.png
  • src/static/images/character-measure.png
  • src/static/images/character-painter.png
  • src/static/images/character-star.png
  • src/static/images/close.png
  • src/static/images/discuss.png
  • src/static/images/dropdown-arrow.png
  • src/static/images/English.png
  • src/static/images/es.png
  • src/static/images/github.png
  • src/static/images/ha-home.png
  • src/static/images/ha.png
  • src/static/images/home-hero-2019-bg.png
  • src/static/images/home-hero-2019.png
  • src/static/images/home-hero-bg.png
  • src/static/images/home-hero.png
  • src/static/images/intro-background-fit.png
  • src/static/images/intro-background.png
  • src/static/images/logo.png
  • src/static/images/logo@2x.png
  • src/static/images/menu.png
  • src/static/images/methodology-banner.png
  • src/static/images/methodology-characters-bg.png
  • src/static/images/methodology-characters.png
  • src/static/images/rectangles.png
  • src/static/images/twitter.png

@tunetheweb
Copy link
Member Author

I've pushed virtually the same fix to the extra-p-tags branch, except that it is in a separate script file. Could we go with that, or is it unnecessary? (Just checking, was about to open a PR.)

Seems a bit excessive IMHO. Especially for a short-term hack (though they often have a habit of hanging around!).

@tunetheweb
Copy link
Member Author

Though do like the name of it (remove_unnecessary_markup.js) as suggests could be used for more than just this hack...

@mikegeyser
Copy link
Contributor

mikegeyser commented Nov 10, 2019 •
edited
Loading

That was my thinking. Keep all of the awful hacks in a single place, so we can go about fixing them. I can merge it into this PR, if that's alright?

@rviscomi rviscomi added the development Building the Almanac tech stack label Nov 10, 2019
@rviscomi rviscomi added this to the SHIP IT! milestone Nov 10, 2019
@tunetheweb
Copy link
Member Author

OK lets close this and go with your fix. Also has the handy extra bonus of blaming you for this complete hack 😀

@rviscomi
Copy link
Member

Open to either approach. I defer to the PR author!

@mikegeyser
Copy link
Contributor

@bazzadp Please take a look, and go ahead if you're happy.

@tunetheweb
Copy link
Member Author

@bazzadp Please take a look, and go ahead if you're happy.

Already looked and happy with your approach. go ahead and raise a PR. Closing this and deleting my branch.

@tunetheweb tunetheweb closed this Nov 10, 2019
@tunetheweb tunetheweb deleted the paragraph_fix_simple branch November 10, 2019 09:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mikegeyser mikegeyser mikegeyser approved these changes

@rviscomi rviscomi rviscomi approved these changes

Assignees
No one assigned
Labels
development Building the Almanac tech stack
Projects
None yet
Milestone
SHIP IT!
Development

Successfully merging this pull request may close these issues.
3 participants
@tunetheweb @mikegeyser @rviscomi