Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate English chapter visualisations to new format #511

Merged
merged 31 commits into from
Nov 25, 2019

Conversation

tunetheweb
Copy link
Member

@tunetheweb tunetheweb commented Nov 18, 2019

Follow on from #491 for the rest of the chapters.

Fixes #432
Fixes #428
Makes progress on #413 (comment)
Makes progress on #379

@tunetheweb tunetheweb marked this pull request as ready for review November 19, 2019 21:10
@tunetheweb
Copy link
Member Author

As discussed in #491 (comment) I think we're good to submit this for other chapters once you are.

@rviscomi rviscomi added the development Building the Almanac tech stack label Nov 21, 2019
@rviscomi rviscomi added this to the Après Ski milestone Nov 21, 2019
Copy link
Member

@rviscomi rviscomi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need to resolve a few merge conflicts. Let me know if this is ok to review after that.

@tunetheweb
Copy link
Member Author

Need to resolve a few merge conflicts. Let me know if this is ok to review after that.

Done!

@tunetheweb
Copy link
Member Author

tunetheweb commented Nov 23, 2019

@rviscomi since we turned the JavaScript chapter on last night as a third chapter on the new format, we've already seen a bigger increase in GA data, which is shown below:

image

A few things to note:

  • Low enough visitors who have sheets-access blocked (0.26%). This will be lower at weekends as suspect it'll be corporates normally blocking, but even so it's very low. It appears my company is an outlier!
  • Low enough visitors who have canvas issues (0.47%). I checked and these are all iPads btw and iPads are approximately 2% of our visitors according to GA.
  • However what we do see, which is more interesting for this change, is that the majority do not enable the interactive figures - and this is because they are on mobile. The new logic therefore be a data saver and performance boast for these users since currently the sheets are being loaded even with display style set to none. I'd be interested in seeing if the new report in Google Search Console leveraging CrUX data show any difference but that'll probably take a few days/weeks to feed through I presume?

Anyway, haven't seen or heard about any issues so I think we're ready to go live with the rest of the chapters if you are comfortable with this and get a chance to review them in this PR?

@rviscomi
Copy link
Member

Your GA analysis SGTM so let's ship it. I didn't go through each line in the PR, I trust everything works.

@tunetheweb tunetheweb merged commit 8470bed into master Nov 25, 2019
@tunetheweb tunetheweb deleted the figures_new_format branch November 25, 2019 19:22
@tunetheweb
Copy link
Member Author

Thanks! That's merged to master and production now. Going to spend a bit testing it all again in production branch to make sure nothing missed and then will push out shortly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
development Building the Almanac tech stack
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fallback Data Vis images don’t display on tablet Fallback when Google Sheets is not available
2 participants