-
-
Notifications
You must be signed in to change notification settings - Fork 171
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Migrate English chapter visualisations to new format #511
Conversation
As discussed in #491 (comment) I think we're good to submit this for other chapters once you are. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Need to resolve a few merge conflicts. Let me know if this is ok to review after that.
Done! |
@rviscomi since we turned the JavaScript chapter on last night as a third chapter on the new format, we've already seen a bigger increase in GA data, which is shown below: A few things to note:
Anyway, haven't seen or heard about any issues so I think we're ready to go live with the rest of the chapters if you are comfortable with this and get a chance to review them in this PR? |
Your GA analysis SGTM so let's ship it. I didn't go through each line in the PR, I trust everything works. |
Thanks! That's merged to master and production now. Going to spend a bit testing it all again in production branch to make sure nothing missed and then will push out shortly. |
Follow on from #491 for the rest of the chapters.
Fixes #432
Fixes #428
Makes progress on #413 (comment)
Makes progress on #379