Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use appropriate chapter hero images #603

Merged
merged 4 commits into from
Jan 3, 2020
Merged

Use appropriate chapter hero images #603

merged 4 commits into from
Jan 3, 2020

Conversation

tunetheweb
Copy link
Member

@tunetheweb tunetheweb commented Dec 27, 2019 •
edited
Loading

Closes #141

Implement <Picture> tag to load large or small hero images for chapters depending on viewport width, pixel density and webp support.

@tunetheweb tunetheweb added the development Building the Almanac tech stack label Dec 27, 2019
@tunetheweb tunetheweb mentioned this pull request Dec 27, 2019
Closed
mikegeyser
mikegeyser approved these changes Jan 3, 2020
View reviewed changes
Copy link
Contributor

@mikegeyser mikegeyser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@tunetheweb tunetheweb merged commit 167694f into master Jan 3, 2020
@tunetheweb tunetheweb deleted the picture_images branch January 3, 2020 08:18
This was referenced Jan 15, 2020
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mikegeyser mikegeyser mikegeyser approved these changes

@logicalphase logicalphase Awaiting requested review from logicalphase

Assignees
No one assigned
Labels
development Building the Almanac tech stack
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Optimize and serve chapter/page illustrations
2 participants
@tunetheweb @mikegeyser