Rewrite SW query to use blink_features #196
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rviscomi
reviewed
Jun 20, 2024
| ROUND(SUM(IF(id = '990' OR feature = 'ServiceWorkerControlledPage', num_urls, 0)) / total_urls * 100, 5) AS percent | ||
| FROM | ||
| `httparchive.pages.*` | ||
| `httparchive.blink_features.usage` |
Member
There was a problem hiding this comment.
Is this table updated by the time the reports are generated? Or is it expected to lag by a month?
Member
Author
There was a problem hiding this comment.
Like all the other blink features queries this one will be delayed. But not by a month, as we rerun the reports on the 2nd of the month specifically because this data is available then.
Eventually we'll rewrite these all to use the all tables at which point this will no longer be an issue but until then I don't see why this SW query needs to be treated differently.
Member
There was a problem hiding this comment.
Just asking what the expected behavior is. Sounds like the lag is WAI, and you're right that it's less than a month.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Blink features will no longer be available in
pagestable and this should be looking at the cheaper table anyway.