Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pretty Please #991

Merged
merged 1 commit into from
May 5, 2024
Merged

Pretty Please #991

merged 1 commit into from
May 5, 2024

Conversation

schmidma
Copy link
Member

@schmidma schmidma commented May 3, 2024

Introduced Changes

Formats generated code with prettyplease instead of rust fmt.

ToDo / Known Issues

none

Ideas for Next Iterations (Not This PR)

none

How to Test

compile and look at the pretty generated code

@schmidma schmidma enabled auto-merge May 3, 2024 19:51
@schmidma schmidma force-pushed the pretty-please branch 2 times, most recently from 13788d4 to 1d0be89 Compare May 5, 2024 11:08
@schmidma schmidma requested a review from rmburg May 5, 2024 18:28
Copy link
Contributor

@knoellle knoellle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks pretty to me

@schmidma schmidma added this pull request to the merge queue May 5, 2024
@schluis
Copy link
Contributor

schluis commented May 5, 2024

Why did you change this?

Merged via the queue into HULKs:main with commit 565d62c May 5, 2024
22 checks passed
@schmidma schmidma deleted the pretty-please branch May 5, 2024 18:37
@schmidma
Copy link
Member Author

schmidma commented May 5, 2024

rustfmt fails to properly format the generated code, prettyplease makes it pretty

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants