Fixed semantic validation error #170
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
best_id_confidence_measure contained an integer/string value 1 instead of the expected CvParameter [MS,MS:1002889,Progenesis MetaScope score,]
|
@nilshoffmann This change I made in response to the proposal in issue #164, but for the purposes of the current spec, yup. Or just a revert of commit 48f4644. |
|
@jmrein that issue slipped my attention. I would propose to keep it as is for now. All other files currently use the "verbose" mode with the explicit CvParam. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
best_id_confidence_measure contained an integer/string value 1 instead of the expected CvParameter [MS,MS:1002889,Progenesis MetaScope score,]
@jmrein I fixed this in the upstream repo, please apply the change to your version as well.