Skip to content

APC - Remove prompt attn with context and use existing implementation #1020

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 15 commits into from
Apr 11, 2025
Merged

APC - Remove prompt attn with context and use existing implementation #1020

merged 15 commits into from
Apr 11, 2025

Conversation

@adobrzyn
Copy link

@adobrzyn adobrzyn commented Apr 7, 2025 •
edited by github-actions bot
Loading

Twin PR: 135

APC will use our implementation of attn

@adobrzyn adobrzyn mentioned this pull request Apr 7, 2025
Merged
@adobrzyn
Copy link
Author

adobrzyn commented Apr 7, 2025

Please run tests

madamczyk-intel
madamczyk-intel requested changes Apr 8, 2025
View reviewed changes
@madamczyk-intel
Copy link

/run-gaudi-tests

2 similar comments
@adobrzyn
Copy link
Author

adobrzyn commented Apr 9, 2025

/run-gaudi-tests

@adobrzyn
Copy link
Author

/run-gaudi-tests

@adobrzyn
Copy link
Author

/run-gaudi-tests

@adobrzyn
Copy link
Author

/run-gaudi-tests

@adobrzyn
Copy link
Author

/run-gaudi-tests

@adobrzyn
Copy link
Author

/run-gaudi-tests

@adobrzyn
Copy link
Author

/run-gaudi-tests

@michalkuligowski
Copy link

/run-gaudi-tests

@adobrzyn adobrzyn mentioned this pull request Apr 11, 2025
Merged
@kzawora-intel kzawora-intel merged commit 22ac593 into habana_main Apr 11, 2025
45 checks passed
@kzawora-intel kzawora-intel deleted the adobrzyn/move_attn_with_context branch April 11, 2025 13:01
michalkuligowski pushed a commit that referenced this pull request Apr 11, 2025
@adobrzyn
APC - Remove prompt attn with context and use existing implementation (…
035db32 
…#1059)

Same PR as [1020](#1020) but
for 1.21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@madamczyk-intel madamczyk-intel madamczyk-intel approved these changes

@kzawora-intel kzawora-intel Awaiting requested review from kzawora-intel kzawora-intel is a code owner

@michalkuligowski michalkuligowski Awaiting requested review from michalkuligowski michalkuligowski is a code owner

@mgawarkiewicz mgawarkiewicz Awaiting requested review from mgawarkiewicz

@vivekgoe vivekgoe Awaiting requested review from vivekgoe vivekgoe is a code owner

@afierka-intel afierka-intel Awaiting requested review from afierka-intel afierka-intel is a code owner

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@adobrzyn @madamczyk-intel @michalkuligowski @kzawora-intel