Fix weights load device use #686
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nirda7
requested review from
kzawora-intel,
madamczykhabana,
michalkuligowski,
mgawarkiewicz,
vivekgoe and
afierka-intel
as code owners
nirda7
force-pushed
the
dev/fix_weights_load_device_use
branch
2 times, most recently
from
78a6adb to
fe82b0b
Compare
nirda7
force-pushed
the
dev/fix_weights_load_device_use
branch
from
fe82b0b to
9105ef2
Compare
nirda7
force-pushed
the
dev/fix_weights_load_device_use
branch
from
9105ef2 to
f6c2559
Compare
kzawora-intel
approved these changes
Jan 16, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some hardware (like TPU) change device in the device_config after the initial setting (None) in their worker's init_device function.
So we cannot set the device to upload the unquantized weights during initialization.