Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix LoRA tests #696

Merged
merged 1 commit into from
Jan 20, 2025
Merged

Fix LoRA tests #696

merged 1 commit into from
Jan 20, 2025

Conversation

SanjuCSudhakaran
Copy link

This PR updates test/lora/utils.py based on latest rebase.

@SanjuCSudhakaran SanjuCSudhakaran marked this pull request as ready for review January 20, 2025 06:44
vivekgoe
vivekgoe approved these changes Jan 20, 2025
View reviewed changes
Copy link

@vivekgoe vivekgoe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@vivekgoe vivekgoe merged commit b10992b into habana_main Jan 20, 2025
31 of 32 checks passed
@SanjuCSudhakaran SanjuCSudhakaran deleted the fix-lora-tests branch January 20, 2025 07:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vivekgoe vivekgoe vivekgoe approved these changes

@kzawora-intel kzawora-intel Awaiting requested review from kzawora-intel kzawora-intel is a code owner

@madamczykhabana madamczykhabana Awaiting requested review from madamczykhabana madamczykhabana is a code owner

@michalkuligowski michalkuligowski Awaiting requested review from michalkuligowski michalkuligowski is a code owner

@mgawarkiewicz mgawarkiewicz Awaiting requested review from mgawarkiewicz mgawarkiewicz is a code owner

@afierka-intel afierka-intel Awaiting requested review from afierka-intel afierka-intel is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@SanjuCSudhakaran @vivekgoe