merged_prefill+ - initial cleanup #942
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
madamczyk-intel
changed the title
…merged_prefill_stage0
…merged_prefill_stage0
Signed-off-by: Michal Adamczyk <madamczyk@habana.ai>
…merged_prefill_stage0
|
/run-gaudi-tests |
madamczyk-intel
requested review from
afierka-intel,
kzawora-intel,
mgawarkiewicz,
michalkuligowski and
vivekgoe
as code owners
Signed-off-by: Michal Adamczyk <madamczyk@habana.ai>
|
/run-gaudi-tests |
madamczyk-intel
changed the title
|
Looks good in terms of multimodal attn |
mswiniarsk
approved these changes
Mar 27, 2025
afierka-intel
approved these changes
Mar 28, 2025
|
/run-gaudi-tests |
1 similar comment
|
/run-gaudi-tests |
|
/run-gaudi-tests |
michalkuligowski
approved these changes
Mar 28, 2025
|
/run-gaudi-tests |
afierka-intel
pushed a commit
that referenced
this pull request
Apr 23, 2025
#942 introduced a fsdpa calibration regression. This PR restores the functionality. Signed-off-by: Michal Adamczyk <madamczyk@habana.ai> Co-authored-by: Michał Kuligowski <mkuligowski@habana.ai>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Coresponding PR: HabanaAI/vllm-hpu-extension#119