[SW-219324] Add block-size 256 to args list #971
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vijethk-intel
requested review from
afierka-intel,
kzawora-intel,
madamczyk-intel,
mgawarkiewicz,
michalkuligowski and
vivekgoe
as code owners
jkaniecki
approved these changes
Mar 27, 2025
kdamaszk
approved these changes
Mar 27, 2025
|
/run-gaudi-tests |
michalkuligowski
approved these changes
Mar 27, 2025
madamczyk-intel
pushed a commit
that referenced
this pull request
May 21, 2025
Bringing back option of 256 as possible block-size arg value, that has been lost in some of the last rebases. It has been first added via #971 The options of arguments are now defined by unpacking predefined type hints  https://github.com/HabanaAI/vllm-fork/blob/habana_main/vllm/engine/arg_utils.py#L611
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
vLLM Llama3.1-70B FP8 2K/2K throughput measurements shows good improvement with blocksize 256 , hence adding this as an option to the argument list