Skip to content

Commit

Permalink
docs: Pin jinja2 to < 3.1.0
Browse files Browse the repository at this point in the history
Jinja2 3.1.0 removed deprecated code that is still used by sphinx
1.8.x, and it looks like our custom sphinx extensions are not working
with more recent versions of sphinx..

See:
- pallets/jinja#1631
- readthedocs/readthedocs.org#9037

and

- PowerDNS#7712

The exact error is:
```
Extension error:
Could not import extension sphinx.builders.latex (exception: cannot import name 'contextfunction' from 'jinja2' (/dnsdist/pdns/dnsdistdist/.venv/lib/python3.7/site-packages/jinja2/__init__.py))
```

(cherry picked from commit 92ad297)
  • Loading branch information
rgacogne authored and Habbie committed Jun 17, 2022
1 parent ff708a2 commit 73dd830
Show file tree
Hide file tree
Showing 3 changed files with 6 additions and 3 deletions.
3 changes: 2 additions & 1 deletion docs/requirements.txt
Original file line number Diff line number Diff line change
Expand Up @@ -4,4 +4,5 @@ git+https://github.com/pieterlexis/sphinx-jsondomain@no-type-links
git+https://github.com/pieterlexis/sphinx-changelog@render-tags
sphinxcontrib-fulltoc
guzzle_sphinx_theme
docutils!=0.15
docutils!=0.15,<0.18
jinja2<3.1.0
3 changes: 2 additions & 1 deletion pdns/dnsdistdist/docs/requirements.txt
Original file line number Diff line number Diff line change
Expand Up @@ -4,4 +4,5 @@ git+https://github.com/pieterlexis/sphinx-jsondomain@no-type-links
git+https://github.com/pieterlexis/sphinx-changelog@render-tags
sphinxcontrib-httpdomain
sphinxcontrib-fulltoc
docutils!=0.15
docutils!=0.15,<0.18
jinja2<3.1.0
3 changes: 2 additions & 1 deletion pdns/recursordist/docs/requirements.txt
Original file line number Diff line number Diff line change
Expand Up @@ -5,4 +5,5 @@ git+https://github.com/pieterlexis/sphinx-changelog@render-tags
guzzle_sphinx_theme
sphinxcontrib.httpdomain
sphinxcontrib-fulltoc
docutils!=0.15
docutils!=0.15,<0.18
jinja2<3.1.0

0 comments on commit 73dd830

Please sign in to comment.