Skip to content

Commit

Permalink
smysql: stop explicity setting MYSQL_OPT_RECONNECT to 0
Browse files Browse the repository at this point in the history
Setting this option, even to 0, causes spurious warnings to the console
with recent libmysqlclient versions. The upstream bug
( https://bugs.mysql.com/bug.php?id=112089 )
has now been open for a month, so we're implementing a workaround.

0 was the default since at least MySQL 5.7, perhaps longer.

closes PowerDNS#13242

(cherry picked from commit f1cbc20)
  • Loading branch information
Habbie committed Oct 6, 2023
1 parent edc5afb commit 84fd2f5
Showing 1 changed file with 0 additions and 5 deletions.
5 changes: 0 additions & 5 deletions modules/gmysqlbackend/smysql.cc
Original file line number Diff line number Diff line change
Expand Up @@ -489,11 +489,6 @@ void SMySQL::connect()

do {

#if MYSQL_VERSION_ID >= 50013
my_bool set_reconnect = 0;
mysql_options(&d_db, MYSQL_OPT_RECONNECT, &set_reconnect);
#endif

#if MYSQL_VERSION_ID >= 50100
if (d_timeout) {
mysql_options(&d_db, MYSQL_OPT_READ_TIMEOUT, &d_timeout);
Expand Down

0 comments on commit 84fd2f5

Please sign in to comment.