-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Difficulty dropdown spacing and alignment issues #13329
Comments
Hi @Tressley , |
@Godwindaniel10 -- Great! It's all yours. 👍🏻 |
Hi @Tressley , I think I can solve this issue. |
I'm not Tressley (or even an admin here on Github or anything) but I think Godwindaniel10 still has it claimed (and hasn't un-claimed it at present?). |
@Harinivas2003 -- Godwindaniel10 is currently working on this issue. Should it become available again in the future, you're more than welcome to take it on. @Godwindaniel10 -- Tagging in our developers @SabreCat @negue to see if they can help you with the issue you're encountering. |
@Tressley alright, thanks, will be looking forward to the solution. meself is still trying out more solutions |
I'm not that experienced with the In that issue it is mentioned to not use
It is the same command as |
@Godwindaniel10 Hi there! Are you still working on this one? If not, or if you don't reply within a week, we're going to mark this as "help wanted" again to make sure people know it's available to work on. Thanks! |
Hi @shanaqui , I am so so sorry for the delay in working on this issue. I should have responded. and I am currently overwhelmed at the moment and I don't want the issue to wait again, so it will be best if someone else works on this issue. |
@Godwindaniel10 No problem, I'll mark the issue as "help wanted" again! |
@sahilcode17 Are you still interested in working on this issue? Please let us know if so. If not, I will mark it as Help Wanted again. Thank you! |
Opening this back up to contributors-- @sahilcode17, if you still want to tackle this, let us know! |
@SabreCat yes but would love if can get help on how can i get started |
Hello 👋 , Can I take this? I think I can resolve it pretty fast |
* Use Flexbox for selectList to get the full width of the selectItems within dropdown * Add a width to selectDifficulty to avoid visual regression when switching selectList to Flexbox
I can take a crack at this, if its not already in progress |
I'm not someone who can give a definitive answer as I'm not, like, staff or something, but I think Guidance for Blacksmiths advises to look at the most recent comment to see if someone's asked to work on it recently and then if you do ask, to wait on admin okay before starting work? (Largely to make sure you don't waste your time, if an admin's answer were to be "no", I guess?) (Again, I'm kind of just regurgitating the guidance page here, and partially because there was someone who asked to work on it, in the comment immediately preceding yours. 🤔) |
Thanks @citrusella, I totally missed the last reply to this before I started work. It was only when I was opening up the PR that I saw that someone had requested to work. I figured I'd open up the PR anyway because I had something. I'll be more mindful on this project in the future, and will definitely understand if the PR gets closed and the ticket assigned to the previous person! |
Yeah, apologies for the delay there! We're implementing some new practices with regards to maintaining these GitHub queues, so turnaround times should start to improve. In any case, we'll give a look at your PR soon! |
The Create and Edit Task modal difficulty dropdown has styling issues. Menu items are no longer vertically centered and the star icons aren't far enough to the right.
The text was updated successfully, but these errors were encountered: