Sidebar component for admin page #14
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ardada2468
requested changes
Oct 20, 2024
There was a problem hiding this comment.
This is good work but just 2 Things
- You need to create a new branch for this pull request because your changes to add mailing functions are also included in this pull request. Please close this PR and create a new one with the new branch.
- Look at my other comment
| </div> | ||
| {/* Only show the menu when the sidebar is not collapsed */} | ||
| {!isCollapsed && ( | ||
| <ul className="sidebar-menu"> |
There was a problem hiding this comment.
We need to be able to pass a list links to the sidebar component. This is to make it reusable across the different pages.
| // Start writing functions | ||
| // https://firebase.google.com/docs/functions/typescript | ||
|
|
||
| // export const helloWorld = onRequest((request, response) => { | ||
| // logger.info("Hello logs!", {structuredData: true}); | ||
| // response.send("Hello from Firebase!"); | ||
| // }); | ||
|
|
There was a problem hiding this comment.
You need to create a new branch to make sure that these changes are not included with this PR
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.