User data Firestore collections + functions #9
Conversation
There was a problem hiding this comment.
Hey guys, great work with these functions. Take a look at my comment about the firestore rules, they seem to have some issues compiling. The other changes I requested are mostly best practices and code quality, so those should be pretty straightforward. Don't hesitate to ping me with any questions!
There was a problem hiding this comment.
These types should go in their own types file so that we can keep our TypeScript types together and separate from the firestore logic.
| @@ -15,5 +15,20 @@ service cloud.firestore { | |||
| match /{document=**} { | |||
| allow read, write: if request.time < timestamp.date(2024, 10, 25); | |||
| } | |||
|
|
|||
| match /applicantUsers/{userId} { | |||
| allow write: request.resource.data.name != null && | |||
There was a problem hiding this comment.
These rules aren't compiling when I run them using the emulator. The applicantUsers rule is definitely missing an "if" but I'm also getting an error on "size". Let me know if you guys need any help testing with the emulator
| import { getAnalytics } from "firebase/analytics"; | ||
| //If this line says import not found then you need to set up firebase api on your machine | ||
| import firebaseConfig from "./firebase_config/FireConfig"; | ||
|
|
||
|
|
||
| const cong = initializeApp(firebaseConfig); | ||
| const firestore = getFirestore(cong); |
There was a problem hiding this comment.
This firestore variable is called "db" on the main branch, so it might be easier to switch that name now before dealing with the merge conflicts.
No description provided.