Highlight correct section when jumping to section via navbar #13 #16
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Put the navbar links in the right order - Use display: table for an element in the location section so that the pixel height value of the section is rounded to the closest integer (it seems like the decimal pixel height value caused the issue with wrong sections being highlighted), this hinted at me at the solution: https://stackoverflow.com/a/13103868 (decimal height value is yielded by bootstrap class 'img-responsive' inside location-card
flowirtz
approved these changes
Jan 9, 2018
|
Bug already existed before. |
jkbe
commented
Jan 9, 2018
| <!--http://eventbrite.com/tickets-external?eid=19275761321&ref=etckt--> | ||
| <iframe src="../hackhpi_assets/tickets-external" frameborder="0" height="540" width="100%" vspace="0" hspace="0" marginheight="5" marginwidth="5" scrolling="auto" allowtransparency="true" style="height: 540px!important; width:100%;"></iframe> | ||
| </div> | ||
| <p class="text-center">The ticket sale is closed now.</p> |
There was a problem hiding this comment.
Does it look ok like this? Because the "col-md-12" is missing.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #13.
the pixel height value of the section is rounded to the closest integer
(it seems like the decimal pixel height value caused the issue with
wrong sections being highlighted), this hinted me at the solution:
https://stackoverflow.com/a/13103868 (decimal height value is yielded
by bootstrap class 'img-responsive' inside location-card