Team recommendation update #50
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* can now change the name of a team * added shortuuid module into requirements.txt * /users/profile returns the user's id (uuid string) if the user is not in a team the team_id field will be an empty string * merged with develop * removed double imports * standardize field names in /user/profiles /teams /teams/ * combined .pop() into 1 line * update user endpoint to return user_id for each user object and set default value of seriousness to 3 * deleted a comment
…recommendation_update
* can now change the name of a team * added shortuuid module into requirements.txt * /users/profile returns the user's id (uuid string) if the user is not in a team the team_id field will be an empty string * merged with develop * removed double imports * standardize field names in /user/profiles /teams /teams/ * combined .pop() into 1 line * update user endpoint to return user_id for each user object and set default value of seriousness to 3 * deleted a comment * fixed so that user cannot invite themselves or send duplicate invites. Also after a merge takes place, the backend will proactively remove any lingering incoming and outgoing invites of the merged in team. * backend now proactively removes outgoing and incoming invites of a team once this team reaches full capacity (4 people) * users are now put back into their own team on leave and prevents users from leaving if they are alone
* fix bug with removing unwanted matches * remove unwanted teams from /teams, add total count * revert invited teams removal from /teams, add invite field to team response * add LICENSE
� Conflicts: � src/matching/team_recommendations.py
anitejb
requested changes
Feb 22, 2021
| list_of_fields = interests | ||
| list_of_fields.extend(prizes) | ||
| list_of_fields.sort() | ||
| bio += ''.join(list_of_fields) |
There was a problem hiding this comment.
Style thing: let's try to stick to double quotes ""
| def lv_distance(user, user2): | ||
| user_str = parse_user_to_string(user) | ||
| team_mate_str = parse_user_to_string(user2) | ||
| return fuzz.token_set_ratio(user_str, team_mate_str) |
There was a problem hiding this comment.
Could we add a comment here briefly explaining what token_set_ratio does
| for member in all_open_members: | ||
| team_id = member["team_id"] | ||
| dis = lv_distance(user, member) | ||
| if team_id in team_map: |
There was a problem hiding this comment.
I think this should be if team_id not in team_map - might want to double check this
| front_pers = front_num/(front_num+back_num) | ||
| back_pers = 1-front_pers | ||
| if front_pers > back_pers: | ||
| if front_pers < 0.3: |
There was a problem hiding this comment.
This number seems arbitrary - is there a reason we picked this? Might be better to just do a direct greater than/less than comparison
| intersection_size = len(set(target_team_skills).intersection(needed_skills)) | ||
| team_map[team_id] *= (intersection_size * skills_weight) | ||
| team_seriousness = target_team["meta"]["seriousness"] | ||
| team_map[team_id] = team_map[team_id] * (intersection_size * skills_weight) * \ |
There was a problem hiding this comment.
Having weights makes sense, but we might want to run a few test scenarios and see how much it actually affects things. For example, we would not want to recommend seriousness 1 to seriousness 5 - that should be a pretty significant difference, meaning more weight.
| @@ -1,6 +1,14 @@ | |||
| from src.flaskapp.db import coll | |||
|
|
|||
|
|
|||
| def get_partial_profile(email): | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
new matching algo using fuzzy string comparison.