Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reorganise whois.set functionality #130

Open
wants to merge 8 commits into
base: main
Choose a base branch
from

Commits on Jun 30, 2018

  1. Reorganise whois.set functionality

    Alias !whois.set to !whois.setdefault and add !whois.setlocal.
    Also alias !whois.unset to !whois.unsetdefault and add !whois.unsetlocal
    bensimner committed Jun 30, 2018
    Configuration menu
    Copy the full SHA
    44ade5e View commit details
    Browse the repository at this point in the history
  2. Remove fullstops from help text

    Pedantic change to be consistent.
    bensimner committed Jun 30, 2018
    Configuration menu
    Copy the full SHA
    39ed3ba View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    3bb4b91 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    24c3c45 View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    b4e4375 View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    988ce53 View commit details
    Browse the repository at this point in the history
  7. Configuration menu
    Copy the full SHA
    ff0bc74 View commit details
    Browse the repository at this point in the history

Commits on Jul 1, 2018

  1. Better UX

    This change makes !set always succeed in setting the whois for this channel, but it will now never over-write the global value if one exists.
    It also means that !unset behaves similarly, it always succeeds in unsetting whichever whois was set for the channel, including removing the global one should it exist.
    I think more work needs to be done to decide whether that last decision is a good one: removing/setting global data on accident is bad UX but it's better than what we currently have, and better than unexpectedly being unable to set the whois.
    bensimner committed Jul 1, 2018
    Configuration menu
    Copy the full SHA
    6ebb66a View commit details
    Browse the repository at this point in the history