-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Reorganise whois.set functionality #130
Open
bensimner
wants to merge
8
commits into
HackSoc:main
Choose a base branch
from
bensimner:whois-setdefault-default
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Commits on Jun 30, 2018
-
Reorganise whois.set functionality
Alias !whois.set to !whois.setdefault and add !whois.setlocal. Also alias !whois.unset to !whois.unsetdefault and add !whois.unsetlocal
Configuration menu - View commit details
-
Copy full SHA for 44ade5e - Browse repository at this point
Copy the full SHA 44ade5eView commit details -
Configuration menu - View commit details
-
Copy full SHA for 39ed3ba - Browse repository at this point
Copy the full SHA 39ed3baView commit details -
Configuration menu - View commit details
-
Copy full SHA for 3bb4b91 - Browse repository at this point
Copy the full SHA 3bb4b91View commit details -
Configuration menu - View commit details
-
Copy full SHA for 24c3c45 - Browse repository at this point
Copy the full SHA 24c3c45View commit details -
Configuration menu - View commit details
-
Copy full SHA for b4e4375 - Browse repository at this point
Copy the full SHA b4e4375View commit details -
Configuration menu - View commit details
-
Copy full SHA for 988ce53 - Browse repository at this point
Copy the full SHA 988ce53View commit details -
Configuration menu - View commit details
-
Copy full SHA for ff0bc74 - Browse repository at this point
Copy the full SHA ff0bc74View commit details
Commits on Jul 1, 2018
-
This change makes !set always succeed in setting the whois for this channel, but it will now never over-write the global value if one exists. It also means that !unset behaves similarly, it always succeeds in unsetting whichever whois was set for the channel, including removing the global one should it exist. I think more work needs to be done to decide whether that last decision is a good one: removing/setting global data on accident is bad UX but it's better than what we currently have, and better than unexpectedly being unable to set the whois.
Configuration menu - View commit details
-
Copy full SHA for 6ebb66a - Browse repository at this point
Copy the full SHA 6ebb66aView commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.