Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleanup #170

Merged
merged 14 commits into from
Feb 19, 2022
Merged

Cleanup #170

merged 14 commits into from
Feb 19, 2022

Conversation

alanbriolat
Copy link
Member

  • Remove some dead code
  • Replace some custom hacky things with "attrs" library
  • Document some things
  • Update some dependencies
  • Remove dependency on straight.plugin
  • Refactor CLI into a separate module

@coveralls
Copy link

Coverage Status

Coverage decreased (-1.5%) to 73.371% when pulling 4585bdd on alanbriolat:cleanup into ae6db31 on HackSoc:master.

@alanbriolat alanbriolat marked this pull request as draft February 19, 2022 12:13
@alanbriolat alanbriolat changed the title WIP: Cleanup Cleanup Feb 19, 2022
@codecov-commenter
Copy link

codecov-commenter commented Feb 19, 2022

Codecov Report

Merging #170 (b6113b6) into main (63ac305) will decrease coverage by 1.25%.
The diff coverage is 30.73%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #170      +/-   ##
==========================================
- Coverage   77.10%   75.85%   -1.26%     
==========================================
  Files          29       28       -1     
  Lines        3062     2990      -72     
  Branches      518      501      -17     
==========================================
- Hits         2361     2268      -93     
- Misses        627      652      +25     
+ Partials       74       70       -4     
Impacted Files Coverage Δ
src/csbot/cli.py 0.00% <0.00%> (ø)
src/csbot/events.py 99.08% <ø> (-0.35%) ⬇️
src/csbot/plugins/github.py 83.01% <ø> (ø)
src/csbot/plugins/webhook.py 100.00% <ø> (ø)
src/csbot/plugins/webserver.py 68.96% <ø> (ø)
src/csbot/util.py 86.11% <67.85%> (+0.25%) ⬆️
src/csbot/irc.py 85.05% <100.00%> (+0.38%) ⬆️
src/csbot/plugin.py 86.16% <100.00%> (+0.56%) ⬆️
src/csbot/plugins/imgur.py 100.00% <100.00%> (ø)
src/csbot/plugins/linkinfo.py 81.96% <100.00%> (+0.93%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 63ac305...b6113b6. Read the comment docs.

@alanbriolat alanbriolat marked this pull request as ready for review February 19, 2022 12:29
@alanbriolat alanbriolat merged commit 645fbd5 into HackSoc:main Feb 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants