Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix test 3 assertion in 1-write-callbacks.js exercise #20

Merged

Conversation

dannyelcf
Copy link

@dannyelcf dannyelcf commented Mar 21, 2024

Description

One of our students found this bug in our exercises. Follow here the discussion: https://hyfbe.slack.com/archives/C066S1ZP5PH/p1711020395859709

So, this PR fix the Test 3 assertion of the isPalindrome exercise.

-+(*)+- is not a palindrome

Screenshot 2024-03-21 at 14 00 42

Checklists

General Checks

  • the branch is up to date with main/master
  • the code works when pulled and run locally
  • All CI checks pass
  • all conflicts are resolved (if any)
  • PR has a descriptive title
  • PR has appropriate labels and milestones for easy identification
  • PR it is assigned to the owner
  • reviewers are assigned
  • the PR contributes only one focused change
  • It is in the appropriate column in the project board (if necessary)
  • has short and clear description
  • is linked to an issue (if it is related)
  • feedback is addressed (if any and if it is appropriate feedback.)

Markdown

  • the markdown source is formatted
  • spelling and grammar is correct in all text
  • The markdown looks correct when you preview the file
  • all links and images work

@dannyelcf
Copy link
Author

Hello @danielhalasz, hello @samirm00

Could you review this PR, please.

Copy link
Member

@danielhalasz danielhalasz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@danielhalasz danielhalasz merged commit 97c01ef into HackYourFutureBelgium:main Mar 21, 2024
Smita81 added a commit to Smita81/inside-js that referenced this pull request Mar 23, 2024
Fix test 3 assertion in 1-write-callbacks.js exercise (HackYourFutureBelgium#20)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants