Skip to content
This repository has been archived by the owner on Nov 20, 2023. It is now read-only.

Updated SAML/SSO documentation #1175

Merged
merged 2 commits into from
Sep 28, 2023
Merged

Conversation

hendrik-hackerone
Copy link
Contributor

No description provided.

Copy link

@pullrequest pullrequest bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ This pull request was not sent to the PullRequest network because the pull request is a draft.

@hendrik-hackerone hendrik-hackerone marked this pull request as ready for review September 28, 2023 13:08
Copy link

@pullrequest pullrequest bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ This pull request was sent to the PullRequest network.


@hendrik-hackerone you can click here to see the review status or cancel the code review job.

Copy link

@pullrequest pullrequest bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PullRequest Breakdown

Reviewable lines of change

+ 83
- 87

82% Markdown
18% YAML
<1% Other
<1% Other (tests)

Type of change

Feature - These changes are adding a new feature or improvement to existing code.
1 Message
📚 It looks like the description for this pull request is either blank or very short. Adding a high-level summary will help our reviewers provide better feedback. Feel free to include questions for PullRequest reviewers and make specific feedback requests.

Copy link

@pullrequest pullrequest bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I added a few nitpicky comments, but also the step order might be wrong in one place that I pointed out.

Image of Dallas Dallas


Reviewed with ❤️ by PullRequest

docs/organizations/single-sign-on-sso-via-saml.md Outdated Show resolved Hide resolved
docs/organizations/single-sign-on-sso-via-saml.md Outdated Show resolved Hide resolved
docs/organizations/sso-jit.md Outdated Show resolved Hide resolved
docs/organizations/verified-domains.md Outdated Show resolved Hide resolved
@hendrik-hackerone
Copy link
Contributor Author

I added a few nitpicky comments, but also the step order might be wrong in one place that I pointed out.

Image of Dallas Dallas

Reviewed with ❤️ by PullRequest

Thanks for your suggestions!

@hendrik-hackerone hendrik-hackerone merged commit 65c452f into master Sep 28, 2023
3 checks passed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants