-
Notifications
You must be signed in to change notification settings - Fork 2.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Issue with the existing Test cases #5137
Closed
balajis-qb opened this issue
Sep 30, 2024
· 1 comment
· Fixed by qburst/react-datepicker-3#33 or #5138
Closed
Issue with the existing Test cases #5137
balajis-qb opened this issue
Sep 30, 2024
· 1 comment
· Fixed by qburst/react-datepicker-3#33 or #5138
Comments
@martijnrusschen, Please assign this issue to me. I'll raise a Fix PR in sometime. |
This was referenced Sep 30, 2024
martijnrusschen
added a commit
that referenced
this issue
Sep 30, 2024
…case Fix #5137: 🧪✅ Fix the accidental change of the complete month issue with the test cases by selecting to a earlier date in a month
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Describe the bug
When I was working on one of the other bugs in this repo, I accidentally found this issue with the existing test cases. The issue we're having is with the test module
datepicker_test.test.js
. There currently 2 test blocks are having an issue as I mentioned in the attached screenshotDatePicker › should be possible to preSelect minDate (no maxDate set)
DatePicker › should be possible to preSelect minDate (maxDate set)
To Reproduce
Just execute
yarn test
at the end of the month (like today) or update the selected date and the minDate to the last date of a month and we'll get this issue.Why this Bug?
I shared one of the failed test cases in the above screenshot. The issue there is we're initially getting a selected day using
const selectedDayNode = getSelectedDayNode(data.container)
and then doing right and left arrow click over it. This test case will work in most of the days except the last day of a month. Because, let's consider 30th sept, 2024 as the selected date. When the user press right, a new month view will get rendered and then the existing selectedDayNode will not be available to us anymore. But in our code we didn't refetch the selectedDayNode and do Left click on it. So only the left click didn't get fired and the test case failed.If the selected date is not the end of the month, this test case will work. Because, eventhough the actual selecteDayNode gets changed to the next date on the initial right arrow click, but still the date we stored in selecteDayNode is still accessible to us and left click over it, will inturn handled by the corresponding component and the test case will pass.
The same issue happens in the other mentioned test case
Possible Fixes:
There are 2 ways to fix the issue
I'll fix the issue like the above mentioned 2nd way.
The text was updated successfully, but these errors were encountered: