Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

package.json: Allow React 16 as a peer dependency #1080

Merged
merged 1 commit into from
Oct 21, 2017

Conversation

rufman
Copy link
Contributor

@rufman rufman commented Oct 20, 2017

No description provided.

@codecov
Copy link

codecov bot commented Oct 20, 2017

Codecov Report

Merging #1080 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1080   +/-   ##
=======================================
  Coverage   84.09%   84.09%           
=======================================
  Files          13       13           
  Lines         874      874           
  Branches      148      148           
=======================================
  Hits          735      735           
  Misses         35       35           
  Partials      104      104

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d5c7eaa...37e68c3. Read the comment docs.

@aij
Copy link
Contributor

aij commented Oct 20, 2017

Is that all that's really needed?

From some comments on #972 and #1060 it sounds like it might be... I suppose it would at least prevent people from mixing different versions of React, which seems to never go well.

@rufman
Copy link
Contributor Author

rufman commented Oct 20, 2017

Yeah I tested it on my setup and everything works, except for yarn check which throws a peer dep error. react-popper will need to be updated too once floating-ui/react-popper#59 merges.

@martijnrusschen martijnrusschen merged commit f211e0a into Hacker0x01:master Oct 21, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants